making sure id is urlencoded when using updateDocument #734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday I tried to update existing elasticsearch document using Type class. Because all of my documents ids contain forward slashes elastica was throwing an exception and documents were not updated.
So when using:
(existing document)
$doc->getId() -> '/some/path'
$doc->getData() -> array(data here)
Then using
$type->updateDocument($doc);
Documents was not updated.
I have created a test and fix. Let me know if this is valid. Cheers
Mike