Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening via hot key prevents it from focusing input #28

Closed
rugk opened this issue May 5, 2019 · 3 comments
Closed

Opening via hot key prevents it from focusing input #28

rugk opened this issue May 5, 2019 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@rugk
Copy link
Owner

rugk commented May 5, 2019

STR

  1. Ctrl+Shift+Period

What happens

Input field not focused

image

What should happen

Auto-focus should work.

System

Firefox 66
Linux/GNOME/Fedora 30

@rugk rugk added the bug Something isn't working label May 5, 2019
@Prometheos2
Copy link
Contributor

Prometheos2 commented May 18, 2019

I had a similar bug when clicking on the icon, but I can't reproduce it in a manner to understand the problem.

it seems the browser lose focus on the application during its opening/loading, and the application doesn't reclaim it when properly opened.
If that's the case, then since the application catches the focus when the loading begins, it must due to the browser not knowing on where to focus.

@rugk
Copy link
Owner Author

rugk commented May 19, 2019

What do you refer when saying "application"? The add-on?

If so, yeah, it may be some focus problem, I am not sure. AFAIK this happens on all OSes, but when opening this issue I saw it on Linux/GNOME.

BTW also asked in the Mozilla forum, but there are also not many people, who know what causes this: https://discourse.mozilla.org/t/firefox-internals-what-technically-differenciates-a-hot-key-command-popup-opening-from-click-opening/40307?u=rugkx


In any way, one could implement a workaround to constantly re-try (manually) focusing the input field. I've done something similar in my Offline QR Code Generator add-on here:
https://github.com/rugk/offline-qr-code/blob/e900c8878f86f2b3bea5558b686097b766fa9cba/src/popup/modules/UserInterface.js#L132-L165

Obviously, this would be a workaround, because the feature from emoji-mart just does not work… 🤔
(But I also cannot report it to emoji-mart, because I don't know what exactly causes this issue.)

@rugk
Copy link
Owner Author

rugk commented Mar 20, 2020

BTW Firefox seems top have fixed this, at least even when removing my workaround, I cannot reproduce it in Firefox 74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants