Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong icon until refreshment. #75

Closed
Prometheos2 opened this issue Jan 17, 2020 · 2 comments · Fixed by #79
Closed

Wrong icon until refreshment. #75

Prometheos2 opened this issue Jan 17, 2020 · 2 comments · Fixed by #79
Labels
bug Something isn't working
Milestone

Comments

@Prometheos2
Copy link
Contributor

Bug description

The wrong add-on icon appears, despite the parameters.

Steps to reproduce

Currently unknown.

Actual behavior

The transparent add-on icon in the toolbar appears instead of the colored one (🤩).

Disabling and re-enabling the icon parameter seems to revert the problem temporarily.

Expected behavior

Having the icon corresponding to the selected parameter.

System

Operating system and version:
Browser and version: Firefox
Add-on version: 1.2 (January 15, 2020)

Possible solution

The problem seems to have been created in recent versions since it wasn't there before (for me).

@Prometheos2 Prometheos2 added the bug Something isn't working label Jan 17, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@rugk
Copy link
Owner

rugk commented Jan 20, 2020

Reproduced. Just opening the settings page also fixes it.

Likely an issue in the init code or so.

Okay found the issue, seems I accidentially deleted the whole icon handler that sets the icon on startup(?). This is how it's supposed to be.

@rugk rugk added this to the next milestone Jan 20, 2020
@rugk rugk mentioned this issue Jan 21, 2020
@rugk rugk closed this as completed in 046416d Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants