Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests #76

Closed
rugk opened this issue May 12, 2018 · 4 comments
Closed

Unit tests #76

rugk opened this issue May 12, 2018 · 4 comments
Labels
code quality enhancement New feature or request
Milestone

Comments

@rugk
Copy link
Owner

rugk commented May 12, 2018

I heard that's something one should do… 😜

@rugk rugk added enhancement New feature or request code quality labels May 12, 2018
@rugk rugk mentioned this issue May 16, 2018
@rugk rugk added this to the 1.3 milestone Jul 4, 2018
@rugk
Copy link
Owner Author

rugk commented Jul 10, 2018

On the way of finding a nice unit testing library… (for WebExtension & ES6 moduloe-compatile tests)

If anyone has any experience/suggestions, feel free to comment.

So I'd consider Mocha and https://istanbul.js.org/… but we'll see.

@OogieBoogieInJSON
Copy link
Contributor

It should be just as usual. Just mock the WebExtension API globals and it will be fine. As for framework, I'd suggest ava or tap they are simple and a less complicated API. My 2 cents.

@rugk
Copy link
Owner Author

rugk commented Jul 16, 2018

The problems here are mocking ES6 modules. I guess I'll use mocha and sinon. Good thing is it can also run in a browser. ava or so features parallel text executions, which I don't really need.

@rugk rugk mentioned this issue Aug 5, 2018
@rugk rugk closed this as completed in #116 Oct 6, 2018
@rugk
Copy link
Owner Author

rugk commented Oct 6, 2018

Finished. 🎉

image

And contributor-friendly, so you can just run it in your browser with 0 setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants