-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to disable crisp mode of Canvas (kjua) library #91
Comments
I'd like to give this a try. I'm a first-time contributor so please let me know if there's anything I'm doing wrong. |
Yeah, thanks. Sure. Let me know if you have any questions. 😃 |
@mitcheesta Are you still interested in it? If not, that's no problem, just add a notice, so I know what the current status of this issue is. |
Hi, I would like to give this a try. |
Thanks, sure, feel free to take this on. 😃 |
@rugk Thanks! |
@heanzyzabala If you need any pointers/help or have questions, feel free to ask. |
One problem the crisp setting is causing is #90.
So we could make it optional, so one can use the Canvas without the crisp setting.
BTW the SVG version has no pixel-perfect (crisp) rendering mode.
This requires:
this option should be dynamically disabled (and unchecked!) when the SVG version is chosenwhen the Canvas is chosen, it should be enabled (and if there is a setting, the old state of the setting should be restored)offline-qr-code/src/popup/qrcode.js
Line 172 in 137a2a3
The text was updated successfully, but these errors were encountered: