Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable crisp mode of Canvas (kjua) library #91

Open
rugk opened this issue May 22, 2018 · 7 comments
Open

Option to disable crisp mode of Canvas (kjua) library #91

rugk opened this issue May 22, 2018 · 7 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest 2020, https://hacktoberfest.digitalocean.com

Comments

@rugk
Copy link
Owner

rugk commented May 22, 2018

One problem the crisp setting is causing is #90.

So we could make it optional, so one can use the Canvas without the crisp setting.

BTW the SVG version has no pixel-perfect (crisp) rendering mode.

This requires:

  • a new QR code size option
  • this option should be dynamically disabled (and unchecked!) when the SVG version is chosen
  • when the Canvas is chosen, it should be enabled (and if there is a setting, the old state of the setting should be restored)
  • by default the setting should be enabled
  • adjustments in the popup of this setting:
    crisp: true,
@rugk rugk added enhancement New feature or request good first issue Good for newcomers labels May 22, 2018
@rugk rugk added the hacktoberfest Hacktoberfest 2020, https://hacktoberfest.digitalocean.com label Oct 14, 2018
@rugk rugk removed the hacktoberfest Hacktoberfest 2020, https://hacktoberfest.digitalocean.com label Oct 31, 2018
@rugk rugk added the hacktoberfest Hacktoberfest 2020, https://hacktoberfest.digitalocean.com label Sep 25, 2019
@mitcheesta
Copy link

I'd like to give this a try. I'm a first-time contributor so please let me know if there's anything I'm doing wrong.

@rugk
Copy link
Owner Author

rugk commented Oct 12, 2019

Yeah, thanks. Sure. Let me know if you have any questions. 😃

@rugk rugk removed the hacktoberfest Hacktoberfest 2020, https://hacktoberfest.digitalocean.com label Nov 7, 2019
@rugk
Copy link
Owner Author

rugk commented Jan 24, 2020

@mitcheesta Are you still interested in it? If not, that's no problem, just add a notice, so I know what the current status of this issue is.

@heanzyzabala
Copy link

Hi, I would like to give this a try.

@rugk
Copy link
Owner Author

rugk commented Jul 26, 2020

Thanks, sure, feel free to take this on. 😃

@rugk rugk assigned heanzyzabala and unassigned mitcheesta Jul 26, 2020
@heanzyzabala
Copy link

@rugk Thanks!

@rugk rugk added the hacktoberfest Hacktoberfest 2020, https://hacktoberfest.digitalocean.com label Sep 29, 2020
@rugk
Copy link
Owner Author

rugk commented Sep 29, 2020

@heanzyzabala If you need any pointers/help or have questions, feel free to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest 2020, https://hacktoberfest.digitalocean.com
Projects
None yet
Development

No branches or pull requests

3 participants