Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://ar.al/ Vimeo Embed Inverted #39

Closed
elsiehupp opened this issue Sep 19, 2021 · 2 comments · Fixed by #41
Closed

https://ar.al/ Vimeo Embed Inverted #39

elsiehupp opened this issue Sep 19, 2021 · 2 comments · Fixed by #41
Assignees
Labels
bug Something isn't working site-issue specific issue on one site
Milestone

Comments

@elsiehupp
Copy link

Affected website: https://ar.al/

Bug description

On the homepage of the website there is a Vimeo embed. With Dark Website Forcer enabled and toggled on, the embed is inverted. When Dark Website Forcer is disabled or toggled off, the website correctly reflects the system settings (on Firefox 92.0 on macOS 11.5.2).

Steps to reproduce

  1. Go to https://ar.al/
  2. Toggle Dark Website Forcer on and off
  3. The website appears correctly (dark or light) with Dark Website Forcer off and the Vimeo embed is inverted with Dark Website Forcer on, regardless.

Screencast/Screenshots

With macOS "Light Appearance" and Dark Website Forcer toggled off:

Light mode (default)

With macOS "Dark Appearance" and Dark Website Forcer toggled off:

Dark mode (default)

With any macOS Appearance and Dark Website Forcer toggled on:

Inverted Vimeo Embed

Actual behavior

See above.

Expected behavior

Nothing should happen.

System

Operating system and version: macOS 11.5.2
Browser and version: Firefox Firefox 92.0
Add-on version: 1.2

Possible solution

idk. This doesn't seem like something that should happen in the first place.

@elsiehupp elsiehupp added bug Something isn't working site-issue specific issue on one site labels Sep 19, 2021
@rugk
Copy link
Owner

rugk commented Sep 19, 2021

Hu, that looks fun! 😅

@rugk rugk linked a pull request Dec 7, 2021 that will close this issue
@rugk rugk self-assigned this Dec 7, 2021
@rugk rugk closed this as completed in #41 Dec 7, 2021
@rugk rugk added this to the 2.0 milestone Dec 8, 2021
@rugk
Copy link
Owner

rugk commented Dec 8, 2021

Hi, I have great news for you! According to my testing, the latest v2.0 release fixes this issue due to the way it now uses a completely new API to do "dark-mode-changing" "properly". For more information, please see the release notes. If the issue should not be fixed, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working site-issue specific issue on one site
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants