Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules break with Bazel 7 due to nocopts #292

Closed
jmmv opened this issue Oct 31, 2023 · 2 comments
Closed

Rules break with Bazel 7 due to nocopts #292

jmmv opened this issue Oct 31, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jmmv
Copy link

jmmv commented Oct 31, 2023

Issue Description

The rules in this repository pass nocopts to the C/C++ rules. They do so via the indirection provided by @rules_cc//cc:defs.bzl. This breaks with Bazel 7, which seems to have lost all support for the nocopts deprecated attribute.

This was probably broken by fe6a20095dd85a49bdf0ec032ba43e32c62056e3 in the bazel.git repository.

Log Output

$ bazel build the:target
INFO: Invocation ID: 77f67304-9e97-406e-8858-62edb068e33e
ERROR: /home/jmmv/workspace/the/target/BUILD.bazel:62:18: //the:some_proto_cc: no such attribute 'nocopts' in 'cc_library' rule (did you mean 'copts'?)

rules_proto_grpc Version

4.3.0 (also fails with 4.5.0)

Bazel Version

release 7.0.0-pre.20231011.2

OS

Linux

Link to Demo Repo

No response

WORKSPACE Content

No response

BUILD Content

No response

Proto Content

No response

Any Other Content

No response

@jmmv jmmv added the bug Something isn't working label Oct 31, 2023
@rdesgroppes
Copy link

I stumbled upon this issue now Bazel 7.0.0 is out.

@axeluhlig
Copy link

Looks like #298 already tried to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants