Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: [Milvus]Partition #16261

Closed
zc277584121 opened this issue Sep 27, 2024 · 1 comment
Closed

[Feature Request]: [Milvus]Partition #16261

zc277584121 opened this issue Sep 27, 2024 · 1 comment
Labels
enhancement New feature or request triage Issue needs to be triaged/prioritized

Comments

@zc277584121
Copy link
Contributor

Feature Description

  • Needs:
    • Milvus has advanced partition management features, e.g. Partition-key, partition-names. They should be introduced into LlamaIndex
  • Methods:
    • New class PartitionConfigs, new param at init partition_configs (PartitionConfigs):
      • partition_key_field(List[str]): defaults to None; if collection does not exist, create with a scalar field (VarChar, max_length 65535).
      • num_partitions(int):defaults to 16; works only if partition_key_field is specified.
      • partition_names(List[str]): defaults to None; if not None:
        • create partitions if not exist
        • load partitions instead of collection (align with Collection load design)
    • Change in other api: When partition_names is given at init, pass it into insert/search etc. if possible.
  • New features examples should be added into https://docs.llamaindex.ai/en/stable/examples/vector_stores/MilvusIndexDemo/
  • Should write and pass corresponding unit test for all new features & changes

Reason

No response

Value of Feature

No response

@zc277584121 zc277584121 added enhancement New feature or request triage Issue needs to be triaged/prioritized labels Sep 27, 2024
Copy link

dosubot bot commented Dec 30, 2024

Hi, @zc277584121. I'm Dosu, and I'm helping the LlamaIndex team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • You proposed integrating advanced partition management features from Milvus into LlamaIndex.
  • Suggested the introduction of a PartitionConfigs class for handling partition configurations.
  • Recommended modifying existing APIs, updating documentation, and adding unit tests.
  • No comments or activity have occurred on this issue since it was opened.

Next Steps:

  • Please let me know if this issue is still relevant to the latest version of the LlamaIndex repository by commenting here to keep the discussion open.
  • If there is no further activity, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 30, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Issue needs to be triaged/prioritized
Projects
None yet
Development

No branches or pull requests

1 participant