Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlantis 0.21.x cause duplicate pipelines in Gitlab #2743

Closed
frimik opened this issue Nov 30, 2022 · 4 comments · Fixed by #2745
Closed

Atlantis 0.21.x cause duplicate pipelines in Gitlab #2743

frimik opened this issue Nov 30, 2022 · 4 comments · Fixed by #2745
Labels
bug Something isn't working provider/gitlab

Comments

@frimik
Copy link

frimik commented Nov 30, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

If you have an internal pipeline in Gitlab, you will now get two separate pipeline IDs - one for the internal and one from the Atlantis commit status update.

Reproduction Steps

Have any pipeline enabled in gitlab via .gitlab-ci.yml AND the atlantis webhook as well. push a change in a merge request branch which starts both flows. You will get two pipeline IDs with each Stage in a separate pipeline.

Environment details

  • Atlantis version: v0.21.x

Additional Context

Going back to v0.20.x restores the proper behaviour.

Slight suspicion it is being caused by #2636 - abb815e

Couldn't find anything else which seems related.

I've now also confirmed that rolling back only the commit from #2636 restores previous behaviour:
image

@frimik frimik added the bug Something isn't working label Nov 30, 2022
@nitrocode
Copy link
Member

@jamengual should we release a patch 0.21.1 ?

@jamengual
Copy link
Contributor

let's wait for @michelmzs to see if he replies?

@michelmzs
Copy link
Contributor

I was able to reproduce the behavior here, we need to add the pipeline_id in the Commit Status to resolve this, I missed that. I can take a look into next days.

@nitrocode
Copy link
Member

@michelmzs released a pre-release version for gitlab users

https://github.com/runatlantis/atlantis/releases/tag/v0.21.0-pre.20221207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working provider/gitlab
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants