pre-workflow-hook step fails due to a websocket error

[mcrivar]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

• Upgraded from v0.18.2 to v0.22.2 to resolve the following issue - Streaming does not appear to work properly with ALB #2026
• After the upgrade, pre_workflow_hook step appeared with -details- option in the steps of PR which was previously not present.

• I'm not sure if its output should be present using details as stated in the docs: "Pre workflow hooks are run outside of Atlantis commands. Which means they do not surface their output back to the PR as a comment."
• Also if the failure of this step is due to WS connection error or the actual hook failure.
  this is the only error I receive from UI on details access for this step

WebSocket connection to 'wss://<URL>/jobs/d1c71b04-7810-40bb-8532-7763b065673b/ws' failed

I will check if I find any errors with the hook which might be an internal issue although I don't experience any impact on tf execution commands, just having it present now is troublesome and fails our CI flow.

If this step could be committed from the outputs and steps - that would be great.

[mcrivar]

so apparently the failure of this step was due to an issue with the hook script, as it was fixed - the failure of this step was gone.

remains just the WS connection issue but again, I guess it was intended to be like that.

[Fabianoshz]

Hi @mcrivar, the websocket error is not expected, do the plan and apply details link work?

[mcrivar]

@Fabianoshz yes they work just fine.

[mcrivar]

@Fabianoshz just to clarify, the step is not failing anymore as the reason for the failure was the actual hook script that was running and had some issues with it. ( the changed name of the issue misrepresents its a bit )

It is just the -details- option that is available now upon this step addition, which does not present any logging of this hook script and has the WS error.

[nitrocode]

To make this easier for others to reproduce, could you share your custom workflow config, output of the working run, and any other details that might help?