Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Custom Wake Word #326

Closed
osterman opened this issue Oct 25, 2018 · 5 comments · Fixed by #2805
Closed

Support Custom Wake Word #326

osterman opened this issue Oct 25, 2018 · 5 comments · Fixed by #2805
Labels
feature New functionality/enhancement help wanted Good feature for contributors

Comments

@osterman
Copy link

osterman commented Oct 25, 2018

what

  • Add wake-word command line argument (E.g. echo vs alexa)

why

  • Allows an atlantis instance to be directly addressable
  • Different wake commands (e.g. 'atlantis/staging' or 'atlantis/prod') can be used to address different atlantis instances when more than one server operates on the same repo.
  • Default should be atlantis

reference

@psalaberria002
Copy link
Contributor

Could you add more information about this feature? What does it solve? And why do you want this to be part of Atlantis?

@osterman
Copy link
Author

use-case

  1. We disable autoplan on the production atlantis watching repo xyz
  2. We run autoplan against xyz on the atlantis instance running in our testing account.
  3. We need to tell the production atlantis to run plan when we want. The current incarnation does not let us address an altantis instance by name. This is why we added the patches listed in the ## references section.

@lkysow
Copy link
Member

lkysow commented Oct 26, 2018

I'm still working on the RFC but I'm thinking about being able to run each atlantis server instance with an optional --name staging flag and then using the atlantis.yaml to be able to tell Atlantis which server instance a particular project should be handled by. Glad to hear you're thinking along the same lines.

Once the RFC is up we can discuss further.

@osterman
Copy link
Author

That sounds good to me!

@lostick
Copy link

lostick commented Nov 19, 2018

that would be a great feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement help wanted Good feature for contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants