0.28.5 destroying using atlantis plan -- -destroy no longer works

[nitrocode]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

I noticed in 0.27.3 that i could use atlantis plan -- -destroy to destroy resources

In 0.28.5 and later, it returns a regular plan instead of a destroy plan.

Reproduction Steps

In older version

1. Open pr
2. Select a dir to destroy
3. Run atlantis plan -d xyz -- -destroy

See destroy plan which shouldn only destroy with 0 create and modify as per docs https://www.runatlantis.io/docs/using-atlantis.html#using-the-destroy-flag

Logs

TBD

Environment details

TBD

Additional Context

N/A

[dosubot]

I found related issues that might be helpful:

• how to atlantis plan -- -destroy for terragrunt custom workflow #612
  This issue discusses using atlantis plan -- -destroy for Terragrunt custom workflows. It was resolved by using custom arguments in the atlantis.yaml file to handle the destroy parameter.

• Add command to enable running terraform destroy #193
  This issue references the ability to run terraform destroy and suggests a similar approach to the one in issue 612.

• schueco/atlantis-docker-image@3854bb1
  This commit shows an implementation for generating a destroy plan using atlantis plan -d some/dir -destroy.

• Add a option do close MR without merge if a destroy command was specified. #4002
  This issue suggests using custom arguments in atlantis.yaml to manage destroy commands, similar to the solution in issue 612.

To continue talking to Dosu, mention @dosu.

[nitrocode]

The issue was replacing the plan in the workflow config with the following which accidentally subtracted the $COMMENT_ARGS

-        - plan
+        - run: |
+            terraform$ATLANTIS_TERRAFORM_VERSION plan -input=false -refresh -out $PLANFILE

and it should have been (or similar)

-        - plan
+        - run: |
+            terraform$ATLANTIS_TERRAFORM_VERSION plan -input=false -refresh -out $PLANFILE $(printf '%s' $COMMENT_ARGS | sed 's/,/ /g' | tr -d '\\')

It might be good to document the default plan and apply stages so if customization is needed, we can keep it 1:1.

Ref

• https://www.runatlantis.io/docs/custom-workflows