Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce an option to lock/prevent applies. #680

Open
natalysheinin opened this issue Jun 14, 2019 · 8 comments
Open

Introduce an option to lock/prevent applies. #680

natalysheinin opened this issue Jun 14, 2019 · 8 comments
Labels
feature New functionality/enhancement

Comments

@natalysheinin
Copy link

Currently, if there is an emergency situation, I can't think of a way to prevent atlantis from running atlantis apply aside from killing the atlantis server which could result in state corruption for any ongoing jobs.

Any ideas? Has anyone run into this?

@lkysow
Copy link
Member

lkysow commented Jun 17, 2019

If you have a load balancer in front you could point it at wrong ports?

@lkysow lkysow added the question Further information is requested label Jun 17, 2019
@natalysheinin
Copy link
Author

natalysheinin commented Jun 17, 2019

I could also delete the webhook, but it would be nice to have a built-in feature in the atlantis server, because then atlantis could deliver custom messages as responses to atlantis plan, making atlantis very user-friendly.

Example atlantis response: atlantis is in lockdown and will not be applying any changes at this time
(we could probably think of something better to write)

@lkysow lkysow added feature New functionality/enhancement and removed question Further information is requested labels Jul 17, 2019
@chadasapp
Copy link

This and #729 could be the same thing yes?

@hossein-rasi
Copy link

I have the same question/requirement. What should I do if I want to use altantis only for planning and not apply?

@lkysow
Copy link
Member

lkysow commented Apr 16, 2020

You could create a default workflow whose apply step is exit 1.

@khateeb15
Copy link

is there a timeline for this to be implemented/released? is anyone working on this at all? if not, can I (or one of my team) raise a PR to implement this? Basically the feature as I see it is introducing an explicit set of people who are allowed to apply or a set of people whose approval is required to apply.

@lkysow
Copy link
Member

lkysow commented Jul 7, 2020

is there a timeline for this to be implemented/released? is anyone working on this at all? if not, can I (or one of my team) raise a PR to implement this? Basically the feature as I see it is introducing an explicit set of people who are allowed to apply or a set of people whose approval is required to apply.

This ticket is not about having a specific set of appliers. This is about having a "Freeze-all-operations" switch that prevents all further Atlantis actions. #308 is what you're asking about. If you want to talk about implementation please use that ticket. And also note that this can be accomplished right now with a custom workflow.

@robert-becker-hs
Copy link

Just in case somebody is stumbling across this as well. The feature has been implemented in Atlantis OSS: #1230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

No branches or pull requests

6 participants