Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically generate README from helm values #230

Closed
Teko012 opened this issue Dec 29, 2022 · 5 comments · Fixed by #371
Closed

Automatically generate README from helm values #230

Teko012 opened this issue Dec 29, 2022 · 5 comments · Fixed by #371
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Teko012
Copy link
Contributor

Teko012 commented Dec 29, 2022

Ideally, the README should be automatically generated by the CI.

Some of the possible options for tooling:

Once the tool has been decided, the values.yaml can be reformatted accordingly.

@Teko012
Copy link
Contributor Author

Teko012 commented Dec 30, 2022

I went through the chart to see what are the missing values in values.yaml, which need to be added first (I was only looking if something can be supplied as value but missing from the values.yaml file).

The values that are missing from the README currently and from the values.yaml:

basicAuthSecretName
fullnameOverride
nameOverride

These are in the README, but not mentioned in the values.yaml:

command
config
environment
ingress.apiVersion
orgWhitelist
service.annotations
service.loadBalancerSourceRanges

All of this will need to be added to the values.yaml file. I haven't checked if there are any that are still mentioned in the README, and not in the code, but I don't think that matters, and it will be fixed when it gets auto generated.

Related:
#231

@Teko012
Copy link
Contributor Author

Teko012 commented Dec 30, 2022

I think readme-generator-for-helm might be better for this, but helm-docs could work too, both lets you specify types as well.

@Teko012
Copy link
Contributor Author

Teko012 commented Jan 2, 2023

We should also unify what is declared by default and what is not: #238 We will have to check if declaring it as an empty value will change some behaviour or not.

@GMartinez-Sisti
Copy link
Member

I've been using norwoodj/helm-docs for this and it works very well. The idea is that values.yaml is your source of truth and every key should have a default value to be documented along with the type. Add a CI job to PRs to ensure the README is always updated and it does wonders.

@GMartinez-Sisti
Copy link
Member

I'll take this one.

@GMartinez-Sisti GMartinez-Sisti self-assigned this Feb 28, 2024
@GMartinez-Sisti GMartinez-Sisti added the documentation Improvements or additions to documentation label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants