fix: Fix run -e/--env tests and add missing variable redefinition #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azhouwd
changed the title
Signed-off-by: Ang Zhou <[email protected]>
azhouwd
force-pushed
the
angzh/fix-env-test
branch
from
d6357a5 to
f1d1df6
Compare
Signed-off-by: Ang Zhou <[email protected]>
azhouwd
force-pushed
the
angzh/fix-env-test
branch
from
afba1dc to
9791a79
Compare
davidhsingyuchen
approved these changes
Jan 17, 2023
sam-berning
pushed a commit
that referenced
this pull request
Jan 18, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.1](v0.3.0...v0.3.1) (2023-01-17) ### Bug Fixes * Fix run -e/--env tests and add missing variable redefinition ([#22](#22)) ([84960f8](84960f8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Currently
run -e/--envtests don't use the env loop variable, instead they are hardcoded into the test string. We need to use the env loop variable.Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.