fix: make tests compatible with nerdctlv1.5 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginglis13
force-pushed
the
test-regressions-nerdctl-upgrade
branch
4 times, most recently
from
af8e887 to
1c6b27c
Compare
pendo324
approved these changes
Aug 8, 2023
vsiravar
reviewed
Aug 8, 2023
nerdctl released v1.5 and we saw some test regressions in runfinch/finch#521: * compose container suffix changed * cp now works with stopped containers * nested bind mounts issue resolved Signed-off-by: Gavin Inglis <[email protected]>
ginglis13
force-pushed
the
test-regressions-nerdctl-upgrade
branch
from
1c6b27c to
a6b3e9f
Compare
vsiravar
approved these changes
Aug 8, 2023
ginglis13
pushed a commit
that referenced
this pull request
Aug 8, 2023
🤖 I have created a release *beep* *boop* --- ## [0.7.2](v0.7.1...v0.7.2) (2023-08-08) ### Bug Fixes * make tests compatible with nerdctlv1.5 ([#75](#75)) ([6876cd0](6876cd0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
nerdctl released v1.5 and we saw some test regressions in runfinch/finch#521:
Follow up PR after in finch to remove
FINCH_DOCKER_COMPATenv variable: runfinch/finch#418Issue #, if available:
Testing done:
pulled down runfinch/finch#521 locally,
replacedirective to point to local common-tests,make test-e2e-containerLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.