fix: Pidfile handling and socket docs #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pendo324
reviewed
Nov 19, 2024
Shubhranshu153
force-pushed
the
main
branch
2 times, most recently
from
198efbd to
7b20b3b
Compare
pendo324
reviewed
Nov 19, 2024
pendo324
reviewed
Nov 19, 2024
Signed-off-by: Shubhranshu153 <[email protected]>
pendo324
approved these changes
Nov 19, 2024
swagatbora90
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
fix: Pidfile handling and socket docs
Pidfile handling in daemon needs to handle concurrent access case and defer should be only be called if the file was created by the same daemon.
Updated the socket docs.
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.