Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add container create options #27

Merged
merged 1 commit into from
Sep 16, 2024
Merged

feat: add container create options #27

merged 1 commit into from
Sep 16, 2024

Conversation

cezar-r
Copy link
Contributor

@cezar-r cezar-r commented Sep 6, 2024 •
edited
Loading

Issue #, if available:

Description of changes:
Added container create options for network, resources, restart policy, and logging.

Testing done:
Passed all unit and e2e tests.

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coderbirju
Copy link
Contributor

Is this a feature or a chore?

@cezar-r
Copy link
Contributor Author

cezar-r commented Sep 6, 2024 •
edited
Loading

Is this a feature or a chore?

I believe that this is a feature @coderbirju

@henry118 henry118 changed the title feat: add container create options to support sagemaker feat: add container create options Sep 6, 2024
@Shubhranshu153
Copy link
Contributor

i believe it requires tests and probably good to separate out the different create options into smaller prs, the name doesnt really make sense in terms of what features we are adding

@cezar-r
Copy link
Contributor Author

cezar-r commented Sep 9, 2024

i believe it requires tests and probably good to separate out the different create options into smaller prs, the name doesnt really make sense in terms of what features we are adding

@Shubhranshu153 okay will add tests. The title of the PR can't exceed 50 characters so I included the categories of the options we are adding in the description. I can also separate this into multiple PR's, @henry118 what do you think?

@henry118
Copy link
Member

henry118 commented Sep 9, 2024

I am fine with one PR but agreed that we should have better tests for the added options, both UT and e2e tests.

@cezar-r cezar-r force-pushed the container-create branch 2 times, most recently from a415d2f to 81e3284 Compare September 11, 2024 21:42
chews93319
chews93319 previously approved these changes Sep 11, 2024
View reviewed changes
@henry118
Copy link
Member

Can you please add a e2e test case for the restart option? This doc has the valid values and expected behavior. Thanks!

@cezar-r cezar-r force-pushed the container-create branch 6 times, most recently from e7bb22f to 514c80c Compare September 13, 2024 20:48
@cezar-r
Copy link
Contributor Author

cezar-r commented Sep 13, 2024

Can you please add a e2e test case for the restart option? This doc has the valid values and expected behavior. Thanks!

Added in latest commit, PTAL

henry118
henry118 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@henry118 henry118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

@cezar-r cezar-r merged commit 504dcaf into runfinch:main Sep 16, 2024
7 checks passed
This was referenced Sep 18, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henry118 henry118 henry118 approved these changes

@coderbirju coderbirju coderbirju approved these changes

@chews93319 chews93319 chews93319 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cezar-r @coderbirju @Shubhranshu153 @henry118 @chews93319