Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect katakana in Nihongo channel folder names #144

Closed
rusq opened this issue Sep 21, 2022 · 3 comments
Closed

Incorrect katakana in Nihongo channel folder names #144

rusq opened this issue Sep 21, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@rusq
Copy link
Owner

rusq commented Sep 21, 2022

Describe the bug
Slack export for JPN contains channel folder names in hankaku, while it should be zenkaku as per this article.

The channel names for attachments, however, are in zenkaku.

This issue was initially mentioned in this discussion post

When the channel name contains Japanese full-width katakana characters, the directory name to save the slack message data (eg. 2022-10-10.json) will be half-width katakana with using slackdump. Attachments are saved in correct full-width katakana directories.

@rusq rusq changed the title Incorrect katakana in Nihongo folder names Incorrect katakana in Nihongo channel folder names Sep 21, 2022
@rusq
Copy link
Owner Author

rusq commented Oct 9, 2022

Sample name:

adapt_w_3dビューア

Issue confirmed:

[7:25:38] 1:wp/_github/slackdump (i144-zen-han)> go run ./cmd/slackdump -export i144.zip -download https://ora600.slack.com/archives/C045TUGSSTW
Slackdump dev Copyright (c) 2018-2077 rusq (build: placeho)

2022/10/09 19:25:43 > checking user cache...
2022/10/09 19:25:43   cache expired: it will be recreated.
2022/10/09 19:25:43 Export:  staring export to: <zip archive: i144.zip>
2022/10/09 19:25:44 messages request #    1, fetched:    4 (threads: 0, files: 1), total:        4 (speed:  13.04/sec, avg:  13.04/sec)
2022/10/09 19:25:44 messages fetch complete, total: 4
2022/10/09 19:25:45 file "F045TUJ5V0C-13_Final_Sin.jpeg" saved to adapt_w_3dビューア/attachments: 361840 bytes written
2022/10/09 19:25:45 completed, time taken: 2.036762078s
[7:25:45] 0:wp/_github/slackdump (i144-zen-han)> 7z l i144.zip 

7-Zip [64] 17.04 : Copyright (c) 1999-2021 Igor Pavlov : 2017-08-28
p7zip Version 17.04 (locale=utf8,Utf16=on,HugeFiles=on,64 bits,16 CPUs x64)

Scanning the drive for archives:
1 file, 358794 bytes (351 KiB)

Listing archive: i144.zip

--
Path = i144.zip
Type = zip
Physical Size = 358794

   Date      Time    Attr         Size   Compressed  Name
------------------- ----- ------------ ------------  ------------------------
2022-10-09 19:25:44 .....         6532         1289  adapt_w_3dビューア/2022-10-09.json
2022-10-09 19:25:44 .....          862          380  channels.json
2022-10-09 19:25:44 .....        15001         1755  users.json
2022-10-09 19:25:45 .....       361840       354652  adapt_w_3dビューア/attachments/F045TUJ5V0C-13_Final_Sin.jpeg
------------------- ----- ------------ ------------  ------------------------
2022-10-09 19:25:45             384235       358076  4 files

@rusq
Copy link
Owner Author

rusq commented Oct 9, 2022

Fixed in #151

@rusq rusq closed this as completed Oct 9, 2022
@rusq
Copy link
Owner Author

rusq commented Oct 9, 2022

Released in https://github.com/rusq/slackdump/releases/tag/v2.2.1

@rusq rusq added the bug Something isn't working label Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant