Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release more often #41

Open
getreu opened this issue Jan 22, 2021 · 26 comments
Open

Please release more often #41

getreu opened this issue Jan 22, 2021 · 26 comments

Comments

@getreu
Copy link

getreu commented Jan 22, 2021

Please release more often. Even a few smaller improvements can make a big difference, according to what the user needs.

For example: I am desperately waiting for
pub fn get_configuration_file_path(name: &str) -> Result<PathBuf, ConfyError>.

The commit 83c3c22 could be easily shipped as intermediate version.

@Zykino
Copy link
Contributor

Zykino commented Jan 23, 2021

Happy to see that my recent addition are really something that peoples want.
I joined the rust-cli group for this exact reason and publish a version with the yaml feature. Now I just want to test a bit #40 and merge it before publishing a version (hopefully early February). And since it will be my first published version for this crate… well I do not want to mess up 😅

@Dylan-DPC-zz
Copy link

Thanks for the issue. For small crates that's the problem as we rarely have much changes so we wait for a bunch of changes which can take a few months and by then people lose interest :D Will check if there's anything else to be bundled with this and if not make a release or assuming Zykino has permissions, let them go ahead :)

@RykoL
Copy link

RykoL commented Feb 12, 2021

I'm also desperately waiting for this function to be available :) . Anyway thanks for that awesome crate 👍

@getreu
Copy link
Author

getreu commented Mar 3, 2021

Any plans when to release?

@let4be
Copy link

let4be commented May 6, 2021

Any update?

@Zykino
Copy link
Contributor

Zykino commented May 6, 2021

I try to ping @Dylan-DPC often on Discord 😅

@Dylan-DPC-zz
Copy link

:D

I'm very sorry for the delays. Been busy the last few months so haven't got to this. Will look into it, this weekend if I can

@AlephAlpha
Copy link

Any update?

@asomers
Copy link

asomers commented Jul 28, 2021

Here's another problem: the directories crate doesn't build with -Z minimal-versions. I see that confy has switched to directories-next. Could you please make a release so we can get that?

@samuelallan72
Copy link

I'm also keen to see a new release - doesn't need to be polished, just needs to be on crates.io. :)

@mistydemeo
Copy link

Is there a way that users could help out to ensure you're confident in a release? Like other users have mentioned, I'm interested in features mentioned in the README that aren't in the version on crates.io, and it'd be great to have an up to date release.

@wzzrd
Copy link

wzzrd commented Jan 16, 2022

Polite ping?

@PiDelport
Copy link
Contributor

It's been almost 2 years since the last release. A new release is very overdue! 🙏🏼

@Dylan-DPC, @Zykino: Does anyone else in the Rust CLI WG have release permissions?

Is there anything that can be done to speed up the release cycle in general? More release automation, more maintainers?

@getreu
Copy link
Author

getreu commented Feb 17, 2022

You are probably better off implementing what Confy does yourself. With Serde it is only a handful lines of code:

source

fn config_load_path(config_path: &Path) -> Result<Cfg, FileError> {
    if config_path.exists() {
        let config: Cfg = toml::from_str(&fs::read_to_string(config_path)?)?;
        // Check for obvious configuration errors.
        // ..
        Ok(config)
    } else {
        fs::create_dir_all(config_path.parent().unwrap_or_else(|| Path::new("")))?;

        let mut buffer = File::create(config_path)?;
        buffer.write_all(toml::to_string_pretty(&Cfg::default())?.as_bytes())?;
        Ok(Cfg::default())
    }
}

@tennox
Copy link

tennox commented Apr 15, 2022

Workaround:

[dependencies]
confy = { git = "https://github.com/rust-cli/confy" }

💁‍♂️

@asomers
Copy link

asomers commented Apr 15, 2022

Workaround:

[dependencies]
confy = {git = "https://github.com/rust-cli/confy" }

Unfortunately @tennox that doesn't work if you want to make a release yourself. Cargo won't let you release a crate that has git dependencies.

@s-burris
Copy link

s-burris commented May 19, 2022

Bumping because I just hit an issue that would have been absolutely impossible to debug without using the git version. Please make a release soon

@Lioness100
Copy link

Polite bump :)

@tobiasvl
Copy link

Are there any major reasons not to just release? It's still at version 0, so semver-wise you don't even strictly need to concern yourself with breaking changes (although it would be nice, of course, but probably not as nice as having an actual release).

@s-burris
Copy link

I asked the author on discord months ago and he said he would but still hasn't. At this point I've switched to reading files / using serde directly

@krissemicolon
Copy link

krissemicolon commented Aug 30, 2022

Any updates? I think ill fork

@deg4uss3r
Copy link
Contributor

The CLI-WG is meeting Monday 2022-09-05 and I want to bring up ownership and maintenance of this crate.

@deg4uss3r
Copy link
Contributor

After the WG meeting we figured we should do a Rosetta analysis of this crate to ensure it's something we (as in the Working Group) want to keep updating and support vice other options (config-rs, figment, other crates we are not aware of).

Please post to this issue if there's specific reasons for confy, none of this means it is going away or anything like that! Just in relation to the working group maintainability. I, personally, do not mind maintaining this crate and releasing but I'd rather do so under the WG if possible.

@tennox
Copy link

tennox commented Sep 7, 2022

Thanks, @deg4uss3r :)

I haven't tried other crates (yet), but i loved the simplicitiy of this crate working out of the box :thumbs_up:

@deg4uss3r
Copy link
Contributor

Version 0.5.0 was released

I'm tempted to close this issue but I would like feedback on my comment above for more data to bring back to the Working Group.

@mistydemeo
Copy link

Thank you very much! I've updated a project to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests