-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is missing before this is a version 1.0.0 release? #76
Comments
Valid question @CaliViking, I think this crate is just about ready for I would like to ensure we're hitting all of the formats people expect as well before we call this library |
Would a good way to update config files to a newer version be within the scope of the project? Currently if a new field is added into a config struct, when an out of date config file is loaded it ends up with i was thinking when it goes to load the config file
Been messing around in a fork to see how to go about implementing such a feature. |
This sound like a big feature (what happens when there is a new field, one is removed, one change type, …). In the same time pub fn load_path<T: Serialize + DeserializeOwned + Default>(
path: impl AsRef<Path>,
) -> Result<T, ConfyError> { I’m not comfortable with it but I remember it being possible to generate a default config and then combining it with another one. So it may be possible to move |
For the different format, Serde’s official list of supported one are here If I remove all binaries one we have left (with my POV on them):
For what I understand all the others are either binary format (and I could be wrong for some), or do only serialization or deserialization. So as of today, of the 6 format more or less available, 3 are already in confy, 2 are kind of domain specific and not specifically for storing config. Rest JSON… I will let you decide its fate. It is still possible to say "we wold love to support XXX even if there are no serde’s binding today". Also, I am not sure adding a new data format later would grant a major version bump. I might be wrong (adding a new feature only mean minor version bump isn’t it?). |
From how the config formats are currently implemented it would be relatively easy to add a new serde supported format with no breaking changes or major code restructure. So i think it adding a new format could get away with a minor version bump.
I've had to write json by hand before, i'd really rather never have to use it for something again. So i have to agree with this point. |
I just remember that In short, it looks like a mix between JSON and XML. From the website:
This may be a good format to add if it take off… Or other format will come to life at some point anyways so expect to add new format (only the popular ones?) with time. |
I see a lot of Rust Crates being stuck in the 0.X release cycle.
What is missing before it can be declared a version 1.0.0?
Do you need community help to complete it?
Just a question.
The text was updated successfully, but these errors were encountered: