Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib doesn't build due to a change in serde #150

Closed
fafk opened this issue Jan 13, 2021 · 2 comments
Closed

Lib doesn't build due to a change in serde #150

fafk opened this issue Jan 13, 2021 · 2 comments

Comments

@fafk
Copy link

fafk commented Jan 13, 2021

Serde changed the visibility of mod export from public to private and it breaks refinery.

serde-rs/serde@dd1f4b4 line 275

error[E0603]: module `export` is private
   --> /Users/fafk/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/refinery-core-0.3.2/src/runner.rs:11:12
    |
11  | use serde::export::Formatter;
    |            ^^^^^^ private module
    |
note: the module `export` is defined here
   --> /Users/fafk/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/serde-1.0.119/src/lib.rs:275:5
    |
275 | use self::__private as export;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0603`.
error: could not compile `refinery-core`
@fafk fafk changed the title Lib doesn't build due to change in serde Lib doesn't build due to a change in serde Jan 13, 2021
@jxs
Copy link
Member

jxs commented Jan 13, 2021

Hi, this has been addressed in master: #149, but i will release a fix ASAP.
thanks

@jxs
Copy link
Member

jxs commented Jan 13, 2021

released refinery_core:0.5.1
do cargo update to update Cargo.lock to use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants