Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose features to select db drivers #33

Closed
onelson opened this issue Dec 25, 2019 · 3 comments
Closed

Expose features to select db drivers #33

onelson opened this issue Dec 25, 2019 · 3 comments

Comments

@onelson
Copy link

onelson commented Dec 25, 2019

I was planning to try refinery_cli for some postgres work, but noticed the crate depends on libsqlite3 whether or not I want to use sqlite.

I didn't have it installed on my system at the time, so the build failed. I thought I'd mention it here as a feature request. Seems like others may have specific dbs in mind and will also want to pick and choose.

Thanks!

@jxs
Copy link
Member

jxs commented Dec 25, 2019

Hi, yeah it totally makes sense, I forgot to include the bundle feature for rusqlite on refinery_cli, and weirdly the CI containers don't complain, but you are right, i am going to allow refinery_cli install to pick the desired driver, and by default pick all 3 with rusqlite having sqlite bundled
thanks!

@jxs jxs closed this as completed in 40f63b8 Dec 25, 2019
@jxs
Copy link
Member

jxs commented Dec 25, 2019

fixed it with #32. I am going to release 0.2 as soon as #30 lands, can you install from git for now?
thanks!

@onelson
Copy link
Author

onelson commented Dec 25, 2019

I uninstalled libsqlite3-dev, reinstalled from git with default features and it worked great.

I also reinstalled with --no-default-features --features postrgres and had similar success. Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants