-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timer trait error mismatch #224
Comments
Maybe the problem in stm32-rs/stm32f4xx-hal#172 could be solved with a different We could also discuss whether a common |
Yeah you got it, thanks!
Given my complaint wasn't valid, and sharing error types there seems fine, unless you have a strong opinion I would rather not add this to the list of things to worry about at this time. |
Great. Glad to help. |
In the timer trait, the
CountDown
andCancel
traits share an error definition, buttry_wait
andtry_cancel
return different types, which is not ideal for implementation. Discovered in stm32-rs/stm32f4xx-hal#172. I'm not sure of the correct change but, any change would be breaking so a decision on this blocks #177.cc. @therealprof
The text was updated successfully, but these errors were encountered: