From 558c79616a7169fbe0e49431e4937f6ca939b932 Mon Sep 17 00:00:00 2001 From: flip1995 Date: Thu, 24 Oct 2019 11:00:32 +0200 Subject: [PATCH 1/8] Blog post on removing the Clippy plugin interface --- ...9-10-24-Clippy-removes-plugin-interface.md | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md diff --git a/posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md b/posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md new file mode 100644 index 000000000..10a40fb08 --- /dev/null +++ b/posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md @@ -0,0 +1,46 @@ +--- +layout: post +title: "Clippy is removing its plugin interface" +author: Philipp Krones +description: "Now that compiler plugins are deprecated, Clippy is also removing its plugin interface" +team: the Dev tools team (Clippy) +--- + +Today we're announcing, that Clippy will completely remove its plugin interface. +Using the plugin interface is deprecated for about one and a half year now +([rust-lang/rust-clippy#2712]) and emits an unsilenceable warning since then. +Now that compiler plugins are officially deprecated ([rust-lang/rust#64675]), +Clippy will remove its support for the plugin interface completely +([rust-lang/rust-clippy#4714]). + +[rust-lang/rust-clippy#2712]: https://github.com/rust-lang/rust-clippy/pull/2712 +[rust-lang/rust#64675]: https://github.com/rust-lang/rust/pull/64675 +[rust-lang/rust-clippy#4714]: https://github.com/rust-lang/rust-clippy/pull/4714 + +### How do I migrate from the plugin interface? + +Since some crates are still using the Clippy plugin interface, we want to +provide a guide on how to migrate to `cargo clippy`. + +1. `Cargo.toml`: Remove every occurrence of the `clippy` dependency and the + `clippy` feature. +2. Completely remove every occurrence of `feature(plugin)` and `plugin(clippy)`. +3. Replace every occurrence of `feature = "clippy"` with `feature = + "cargo-clippy"`. The `cargo-clippy` feature is automatically enabled when + running `cargo clippy`. +4. CI: You now have to install Clippy via rustup, with `rustup component add + clippy`. Once it is installed you can just run `cargo clippy` (for more usage + instructions, see the [Clippy `README`]). Note that Clippy is not included in + every nightly, but you can check its availability on the [rustup components + history] page. + +[Clippy `README`]: https://github.com/rust-lang/rust-clippy#usage +[rustup components history]: https://rust-lang.github.io/rustup-components-history/index.html + +### Where should I go if I have more questions? + +If you need help with migrating from the plugin interface, you can contact us +via [Discord] or open an issue on [GitHub]. + +[Discord]: https://discord.gg/vNNtpyD +[GitHub]: https://github.com/rust-lang/clippy/issues/new From 54588a3c2db7416030c0231f57e4840b4fb8e76d Mon Sep 17 00:00:00 2001 From: flip1995 Date: Thu, 24 Oct 2019 18:42:10 +0200 Subject: [PATCH 2/8] Apply suggestions --- ...19-10-24-Clippy-removes-plugin-interface.md | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md b/posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md index 10a40fb08..ac628b172 100644 --- a/posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md +++ b/posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md @@ -2,16 +2,16 @@ layout: post title: "Clippy is removing its plugin interface" author: Philipp Krones -description: "Now that compiler plugins are deprecated, Clippy is also removing its plugin interface" +description: "Now that compiler plugins are deprecated, Clippy is removing its deprecated plugin interface" team: the Dev tools team (Clippy) --- -Today we're announcing, that Clippy will completely remove its plugin interface. -Using the plugin interface is deprecated for about one and a half year now -([rust-lang/rust-clippy#2712]) and emits an unsilenceable warning since then. -Now that compiler plugins are officially deprecated ([rust-lang/rust#64675]), -Clippy will remove its support for the plugin interface completely -([rust-lang/rust-clippy#4714]). +Today, we're announcing that Clippy will completely remove its plugin interface. +Using the plugin interface has been deprecated for about one and a half year now +([rust-lang/rust-clippy#2712]). Since then, unsilenceable warning have been +emitted. Now that compiler plugins are officially deprecated +([rust-lang/rust#64675]), Clippy will remove its support for the plugin +interface completely ([rust-lang/rust-clippy#4714]). [rust-lang/rust-clippy#2712]: https://github.com/rust-lang/rust-clippy/pull/2712 [rust-lang/rust#64675]: https://github.com/rust-lang/rust/pull/64675 @@ -19,8 +19,8 @@ Clippy will remove its support for the plugin interface completely ### How do I migrate from the plugin interface? -Since some crates are still using the Clippy plugin interface, we want to -provide a guide on how to migrate to `cargo clippy`. +If you are still using the Clippy plugin interface, here are some steps you can +take to migrate to `cargo clippy`. 1. `Cargo.toml`: Remove every occurrence of the `clippy` dependency and the `clippy` feature. From fb996c2d76b659bd0e0baa438789e34fe6d49db6 Mon Sep 17 00:00:00 2001 From: flip1995 Date: Fri, 25 Oct 2019 09:41:40 +0200 Subject: [PATCH 3/8] Apply suggestions --- .../2019-10-24-Clippy-removes-plugin-interface.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md b/posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md index ac628b172..e4326ce5e 100644 --- a/posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md +++ b/posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md @@ -11,7 +11,8 @@ Using the plugin interface has been deprecated for about one and a half year now ([rust-lang/rust-clippy#2712]). Since then, unsilenceable warning have been emitted. Now that compiler plugins are officially deprecated ([rust-lang/rust#64675]), Clippy will remove its support for the plugin -interface completely ([rust-lang/rust-clippy#4714]). +interface completely ([rust-lang/rust-clippy#4714]). This change will hit stable +with version 1.40.0. [rust-lang/rust-clippy#2712]: https://github.com/rust-lang/rust-clippy/pull/2712 [rust-lang/rust#64675]: https://github.com/rust-lang/rust/pull/64675 @@ -29,7 +30,7 @@ take to migrate to `cargo clippy`. "cargo-clippy"`. The `cargo-clippy` feature is automatically enabled when running `cargo clippy`. 4. CI: You now have to install Clippy via rustup, with `rustup component add - clippy`. Once it is installed you can just run `cargo clippy` (for more usage + clippy`. Once installed, you can run `cargo clippy` (for more usage instructions, see the [Clippy `README`]). Note that Clippy is not included in every nightly, but you can check its availability on the [rustup components history] page. From f939fed2611842dae3aa9225c79fbaa59486202a Mon Sep 17 00:00:00 2001 From: flip1995 Date: Fri, 25 Oct 2019 09:50:07 +0200 Subject: [PATCH 4/8] Move to main rust blog --- ...rface.md => 2019-10-25-Clippy-removes-plugin-interface.md} | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) rename posts/{inside-rust/2019-10-24-Clippy-removes-plugin-interface.md => 2019-10-25-Clippy-removes-plugin-interface.md} (90%) diff --git a/posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md b/posts/2019-10-25-Clippy-removes-plugin-interface.md similarity index 90% rename from posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md rename to posts/2019-10-25-Clippy-removes-plugin-interface.md index e4326ce5e..60d53c4a9 100644 --- a/posts/inside-rust/2019-10-24-Clippy-removes-plugin-interface.md +++ b/posts/2019-10-25-Clippy-removes-plugin-interface.md @@ -1,9 +1,7 @@ --- layout: post title: "Clippy is removing its plugin interface" -author: Philipp Krones -description: "Now that compiler plugins are deprecated, Clippy is removing its deprecated plugin interface" -team: the Dev tools team (Clippy) +author: Dev tools team (Clippy) --- Today, we're announcing that Clippy will completely remove its plugin interface. From 25274a6ddfa17092a1a9d6fdf2eeb48faf36f692 Mon Sep 17 00:00:00 2001 From: flip1995 Date: Mon, 4 Nov 2019 13:02:37 +0100 Subject: [PATCH 5/8] Note that this post only affects few people --- .../2019-10-25-Clippy-removes-plugin-interface.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/posts/2019-10-25-Clippy-removes-plugin-interface.md b/posts/2019-10-25-Clippy-removes-plugin-interface.md index 60d53c4a9..d4d74a7a6 100644 --- a/posts/2019-10-25-Clippy-removes-plugin-interface.md +++ b/posts/2019-10-25-Clippy-removes-plugin-interface.md @@ -4,6 +4,20 @@ title: "Clippy is removing its plugin interface" author: Dev tools team (Clippy) --- +### Does this post affect me? + +Most likely, no. This post only affects you, if you're still using Clippy +through its plugin interface. If you do so, you get the warning + +``` +warning: the clippy plugin is being deprecated, please use cargo clippy or rls with the clippy feature +``` + +when compiling your crate. If you don't see this warning, nothing will change +for you. + +### What is removed and why? + Today, we're announcing that Clippy will completely remove its plugin interface. Using the plugin interface has been deprecated for about one and a half year now ([rust-lang/rust-clippy#2712]). Since then, unsilenceable warning have been From 2f79369615f7421c278857e4967d17533f9645ae Mon Sep 17 00:00:00 2001 From: flip1995 Date: Mon, 4 Nov 2019 13:03:17 +0100 Subject: [PATCH 6/8] Move post back to inside-rust blog --- .../2019-11-04-Clippy-removes-plugin-interface.md} | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) rename posts/{2019-10-25-Clippy-removes-plugin-interface.md => inside-rust/2019-11-04-Clippy-removes-plugin-interface.md} (91%) diff --git a/posts/2019-10-25-Clippy-removes-plugin-interface.md b/posts/inside-rust/2019-11-04-Clippy-removes-plugin-interface.md similarity index 91% rename from posts/2019-10-25-Clippy-removes-plugin-interface.md rename to posts/inside-rust/2019-11-04-Clippy-removes-plugin-interface.md index d4d74a7a6..418f02d1b 100644 --- a/posts/2019-10-25-Clippy-removes-plugin-interface.md +++ b/posts/inside-rust/2019-11-04-Clippy-removes-plugin-interface.md @@ -1,7 +1,9 @@ --- layout: post title: "Clippy is removing its plugin interface" -author: Dev tools team (Clippy) +author: Philipp Krones +description: "Now that compiler plugins are deprecated, Clippy is removing its deprecated plugin interface" +team: the Dev tools team (Clippy) --- ### Does this post affect me? From 03e0564ec3883020d54558bb3201031ddc50e418 Mon Sep 17 00:00:00 2001 From: flip1995 Date: Mon, 4 Nov 2019 13:09:00 +0100 Subject: [PATCH 7/8] Swap sections --- ...9-11-04-Clippy-removes-plugin-interface.md | 26 +++++++++---------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/posts/inside-rust/2019-11-04-Clippy-removes-plugin-interface.md b/posts/inside-rust/2019-11-04-Clippy-removes-plugin-interface.md index 418f02d1b..9da25713c 100644 --- a/posts/inside-rust/2019-11-04-Clippy-removes-plugin-interface.md +++ b/posts/inside-rust/2019-11-04-Clippy-removes-plugin-interface.md @@ -6,6 +6,18 @@ description: "Now that compiler plugins are deprecated, Clippy is removing its d team: the Dev tools team (Clippy) --- +Today, we're announcing that Clippy will completely remove its plugin interface. +Using the plugin interface has been deprecated for about one and a half year now +([rust-lang/rust-clippy#2712]). Since then, an unsilenceable warning has been +emitted. Now that compiler plugins are officially deprecated +([rust-lang/rust#64675]), Clippy will remove its support for the plugin +interface completely ([rust-lang/rust-clippy#4714]). This change will hit stable +with version 1.40.0. + +[rust-lang/rust-clippy#2712]: https://github.com/rust-lang/rust-clippy/pull/2712 +[rust-lang/rust#64675]: https://github.com/rust-lang/rust/pull/64675 +[rust-lang/rust-clippy#4714]: https://github.com/rust-lang/rust-clippy/pull/4714 + ### Does this post affect me? Most likely, no. This post only affects you, if you're still using Clippy @@ -18,20 +30,6 @@ warning: the clippy plugin is being deprecated, please use cargo clippy or rls w when compiling your crate. If you don't see this warning, nothing will change for you. -### What is removed and why? - -Today, we're announcing that Clippy will completely remove its plugin interface. -Using the plugin interface has been deprecated for about one and a half year now -([rust-lang/rust-clippy#2712]). Since then, unsilenceable warning have been -emitted. Now that compiler plugins are officially deprecated -([rust-lang/rust#64675]), Clippy will remove its support for the plugin -interface completely ([rust-lang/rust-clippy#4714]). This change will hit stable -with version 1.40.0. - -[rust-lang/rust-clippy#2712]: https://github.com/rust-lang/rust-clippy/pull/2712 -[rust-lang/rust#64675]: https://github.com/rust-lang/rust/pull/64675 -[rust-lang/rust-clippy#4714]: https://github.com/rust-lang/rust-clippy/pull/4714 - ### How do I migrate from the plugin interface? If you are still using the Clippy plugin interface, here are some steps you can From 3b47f7af3e38c794b3f550bb8ef906a4e3cacd40 Mon Sep 17 00:00:00 2001 From: flip1995 Date: Mon, 4 Nov 2019 13:12:29 +0100 Subject: [PATCH 8/8] Update stable rust version affected by this --- posts/inside-rust/2019-11-04-Clippy-removes-plugin-interface.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/posts/inside-rust/2019-11-04-Clippy-removes-plugin-interface.md b/posts/inside-rust/2019-11-04-Clippy-removes-plugin-interface.md index 9da25713c..7b0b78d33 100644 --- a/posts/inside-rust/2019-11-04-Clippy-removes-plugin-interface.md +++ b/posts/inside-rust/2019-11-04-Clippy-removes-plugin-interface.md @@ -12,7 +12,7 @@ Using the plugin interface has been deprecated for about one and a half year now emitted. Now that compiler plugins are officially deprecated ([rust-lang/rust#64675]), Clippy will remove its support for the plugin interface completely ([rust-lang/rust-clippy#4714]). This change will hit stable -with version 1.40.0. +with version 1.41.0. [rust-lang/rust-clippy#2712]: https://github.com/rust-lang/rust-clippy/pull/2712 [rust-lang/rust#64675]: https://github.com/rust-lang/rust/pull/64675