Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPDX License expression link broken #12797

Closed
RossSmyth opened this issue Oct 9, 2023 · 4 comments · Fixed by #12827
Closed

SPDX License expression link broken #12797

RossSmyth opened this issue Oct 9, 2023 · 4 comments · Fixed by #12827
Labels
A-documenting-cargo-itself Area: Cargo's documentation A-interacts-with-crates.io Area: interaction with registries C-bug Category: bug E-easy Experience: Easy S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review

Comments

@RossSmyth
Copy link

Problem

In the Cargo Book, the "SPDX 2.1 license expression" link is broken.

[crates.io] interprets the `license` field as an [SPDX 2.1 license
expression][spdx-2.1-license-expressions]. The name must be a known license

[spdx-2.1-license-expressions]: https://spdx.org/spdx-specification-21-web-version#h.jxpfx0ykyb60

Steps

  1. Go to Cargo Book webpage
  2. Click on "SPDX 2.1 license expression"
  3. See "Page not found" page

Possible Solution(s)

Update the link or complain to SPDX as it looks like the link is broken on their website too

https://spdx.dev/spdx-specification-21-web-version/

So an issue may need to be raised here:

https://github.com/spdx/LicenseListPublisher

Notes

No response

Version

b27f203e7f461a6e98bf78abc88d7e7fc6ff1a8f ?
@RossSmyth RossSmyth added C-bug Category: bug S-triage Status: This issue is waiting on initial triage. labels Oct 9, 2023
@weihanglo
Copy link
Member

Looking at crates.io project, it uses spdx#0.10.2, which at least uses SPDX license expression v2.1 or later.

v2.3 looks like to have the same syntax as v2.1, though I am not knowledgeable enough to tell the difference.

cc @Turbo87, any insight?

@Turbo87
Copy link
Member

Turbo87 commented Oct 9, 2023

interestingly the link to the license expressions in the https://github.com/EmbarkStudios/spdx README is also broken, but AFAIK the syntax is the same as before and only the list of licenses was updated.

even more funny, the link to the 2.1 spec on https://spdx.dev/use/specifications/ is also broken 😅

@weihanglo weihanglo added A-documenting-cargo-itself Area: Cargo's documentation A-interacts-with-crates.io Area: interaction with registries S-blocked-external Status: ❌ blocked on something out of the direct control of the Cargo project, e.g., upstream fix and removed S-triage Status: This issue is waiting on initial triage. labels Oct 12, 2023
@weihanglo
Copy link
Member

Should we just link them to 2.3, as they are quite the same thing? I would love to let you or crates.io team decide as this is more concerned about crates.io

@Turbo87
Copy link
Member

Turbo87 commented Oct 12, 2023

yeah, I guess updating the link to the latest spec should probably be fine

@weihanglo weihanglo added E-easy Experience: Easy S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review and removed S-blocked-external Status: ❌ blocked on something out of the direct control of the Cargo project, e.g., upstream fix labels Oct 12, 2023
@bors bors closed this as completed in c857ebb Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation A-interacts-with-crates.io Area: interaction with registries C-bug Category: bug E-easy Experience: Easy S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants