Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cargo's testsuite faster #6629

Closed
dwijnand opened this issue Feb 4, 2019 · 2 comments
Closed

Make cargo's testsuite faster #6629

dwijnand opened this issue Feb 4, 2019 · 2 comments
Labels
A-testing-cargo-itself Area: cargo's tests

Comments

@dwijnand
Copy link
Member

dwijnand commented Feb 4, 2019

Would splitting up the tests so it doesn't all build into a big testsuite binary make iterating faster?

I'm not 100% convinced myself (but I thought I'd share my thought with the team anyway) because I think the incremental compiler should solve this problem, so is the real problem that we have too many huge test files? (tests/testsuite/test.rs is 3500 lines, tests/testsuite/build.rs is approaching 5000).

@dwijnand dwijnand added the A-testing-cargo-itself Area: cargo's tests label Feb 4, 2019
@ehuss
Copy link
Contributor

ehuss commented Feb 4, 2019

How much time does it typically take to build the testsuite? For me, small changes take about 10s.

It was unified as part of #4867 where having them completely split up was also expensive.

I wonder if it would help much to remove linking cargo-the-lib. Almost all of the tests are just exercising the cargo executable. The few tests that actually use the library could be separated. It looks like there are a few path-related utility functions that could probably have some way of sharing. I suspect it wouldn't help dramatically, though.

@dwijnand
Copy link
Member Author

dwijnand commented Feb 4, 2019

Huh, interesting. Thanks, @ehuss.

@dwijnand dwijnand closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing-cargo-itself Area: cargo's tests
Projects
None yet
Development

No branches or pull requests

2 participants