Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintegrate chalk into rustc #289

Closed
jackh726 opened this issue May 7, 2020 · 2 comments
Closed

Reintegrate chalk into rustc #289

jackh726 opened this issue May 7, 2020 · 2 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@jackh726
Copy link
Member

jackh726 commented May 7, 2020 •
edited
Loading

TL;DR

Reintegrate chalk into rustc using chalk-solve under the -Z chalk flag.

Links and Details

This is working towards the eventual™ goal of using Chalk as the rustc trait solver. There used to be an experimental implementation of Chalk in rustc using chalk-engine. It became outdated and was removed in rust-lang/rust#69247. Since that first experimental implementation was added, Chalk has gone through lots of changes, including adding a new crate, chalk-solve, which is supposed to implement Rust logic. As such, with this newer implementation, the interface between rustc and Chalk is a bit higher-level.

The PR for this initial MVP implementation is here: rust-lang/rust#69406

Mentors or Reviewers

c.c. @nikomatsakis
c.c. @rust-lang/wg-traits
@jackh726 jackh726 added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels May 7, 2020
@rustbot rustbot added the to-announce Announce this issue on triage meeting label May 7, 2020
@nikomatsakis
Copy link
Contributor

@rustbot second

I'm going to exercise the "I consider this unlikely to be controversial clause" and r+ rust-lang/rust#69406 before it bitrots...we can always back it out. (Besides, if I know bors, it'll take 2 weeks to land anyway 😛)

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label May 7, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label May 13, 2020
@nikomatsakis
Copy link
Contributor

Closing, FCP expired. =)

@spastorino spastorino added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spastorino @nikomatsakis @jackh726 @rustbot