Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move graphviz code out of the compiler into external crate #380

Closed
2 of 3 tasks
vn-ki opened this issue Oct 28, 2020 · 2 comments
Closed
2 of 3 tasks

Move graphviz code out of the compiler into external crate #380

vn-ki opened this issue Oct 28, 2020 · 2 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@vn-ki
Copy link

vn-ki commented Oct 28, 2020 •
edited by wesleywiser
Loading

Proposal

MIR visualizations are currently done using graphviz. This is a proposal to move the graphviz code out of the compiler into external crate(s) and implement graph diffing (and graph diff visualization) with this crate.

External crate: https://crates.io/crates/gsgdt
Initial PR implementing MIR graphviz using gsgdt: rust-lang/rust#78399

Mentors or Reviewers

@oli-obk

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@vn-ki vn-ki added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Oct 28, 2020
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2020

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Oct 28, 2020
@wesleywiser
Copy link
Member

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Oct 28, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Oct 29, 2020
@spastorino spastorino added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Nov 11, 2020
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Nov 11, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spastorino @wesleywiser @vn-ki @rustbot