Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ty::WhereClause to align chalk and rustc dyn representation #433

Closed
2 of 3 tasks
csmoe opened this issue May 19, 2021 · 3 comments
Closed
2 of 3 tasks

Introduce ty::WhereClause to align chalk and rustc dyn representation #433

csmoe opened this issue May 19, 2021 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@csmoe
Copy link
Member

csmoe commented May 19, 2021

Proposal

As @nikomatsakis wrote in rust-lang/types-team#30 , chalk's binder + predicate representation seems better than rustc's ExistentialPredicate.
rust-lang/rust#85466 renamed ExistentailPredicate to WhereClause, and created a binder alias:

pub enum WhereClause {
    ...
}
pub type ExistentialPredicate<'tcx> = Binder<'tcx, WhereClause<'tcx>>;

Mentors or Reviewers

@nikomatsakis

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@csmoe csmoe added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels May 19, 2021
@rustbot
Copy link
Collaborator

rustbot commented May 19, 2021

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@jackh726
Copy link
Member

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label May 20, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label May 20, 2021
@apiraino
Copy link
Contributor

apiraino commented Jun 3, 2021

@rustbot label -final-comment-period +major-change-accepted

@apiraino apiraino closed this as completed Jun 3, 2021
@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jun 3, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants