Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make -Z binary-dep-depinfo the default behavior #464

Closed
1 of 3 tasks
fangism opened this issue Sep 24, 2021 · 3 comments
Closed
1 of 3 tasks

Make -Z binary-dep-depinfo the default behavior #464

fangism opened this issue Sep 24, 2021 · 3 comments
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@fangism
Copy link

fangism commented Sep 24, 2021

Proposal

The -Z binary-dep-depinfo feature is extremely useful for identifying direct and transitive dependencies of a rustc command. In practice, this has been used to identify all inputs needed to execute rust compiles/links remotely. This feature generates a complete dep-info file, not just one that lists source files. This effectively adds redundant (harmless) transitive dependency edges.

Proposal is to make this behavior the default, so all dep-info files list their transitive dependencies.

This was also proposed on https://internals.rust-lang.org/t/support-zbinary-dep-depinfo-long-term/15253.

Mentors or Reviewers

[anyone]

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@fangism fangism added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Sep 24, 2021
@rustbot
Copy link
Collaborator

rustbot commented Sep 24, 2021

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Sep 24, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Sep 30, 2021
@pnkfelix
Copy link
Member

FYI: this will be closed in a week if it doesn't get seconded within that time.

See also: https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202022-05-19/near/282934125

@apiraino
Copy link
Contributor

apiraino commented Jun 2, 2022

As announced previously, this issue will be closed (Zulip mention)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

4 participants