Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs.rs failed to build drink-0.9.0 #2410

Closed
pmikolajczyk41 opened this issue Feb 9, 2024 · 7 comments
Closed

docs.rs failed to build drink-0.9.0 #2410

pmikolajczyk41 opened this issue Feb 9, 2024 · 7 comments

Comments

@pmikolajczyk41
Copy link

Crate name

drink

Build failure link

https://docs.rs/crate/drink/0.9.0/builds/1121750

Additional details

Normal cargo doc works fine. My guess is that stdsimd feature was removed in the recent nightly that is used for building docs. Probably relevant errors reported recently: rust-lang/rust#48556

@syphar
Copy link
Member

syphar commented Feb 9, 2024

This is an issue with ahash, see also tkaitchuck/aHash#200

I'm happy to trigger a rebuild if it's fixed.

@syphar
Copy link
Member

syphar commented Feb 14, 2024

@pmikolajczyk41 since ahash was fixed, I triggered a rebuild, now we're seeing another build failure.

Can you check if there also happen locally for you?

@pmikolajczyk41
Copy link
Author

@syphar again, locally works well, fails with stdsimd at ahash

@syphar
Copy link
Member

syphar commented Feb 14, 2024

@syphar again, locally works well, fails with stdsimd at ahash

I don't fully follow, does it work locally or does it fail with ahash / stdsimd?

Looking at the new build failure from my rebuild, the error is not about stdsimd any more:
https://docs.rs/crate/drink/0.9.0/builds/1127301

@pmikolajczyk41
Copy link
Author

oh, I was looking at the most recent version of library, i.e. 0.10.0, where the problem with ahash persists (https://docs.rs/crate/drink/0.10.0/builds/1122573); locally, when I run cargo doc (for version 0.10.0) it succeeds

@syphar
Copy link
Member

syphar commented Feb 16, 2024

I queued a rebuild, and we're now seeing another error, this time with pallet-contracts:
https://docs.rs/crate/drink/0.10.0/builds/1129453

Interestingly, pallet-contracts itself also had this error : https://docs.rs/crate/pallet-contracts/27.0.0/builds/1099632 , and there is a new version that doesn't have it: https://docs.rs/crate/pallet-contracts/28.0.0/builds

So it looks like upgrading pallet-contracts would be the next step to try

@syphar
Copy link
Member

syphar commented Mar 7, 2024

I'm closing the issue under that assumption that the issue is with pallet-contracts and will be fixed with an update now.

Feel free to comment / reopen if not.

@syphar syphar closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants