r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

I expect the authentication to fail, let's see. Probably we need to add the permissions ecr-public:GetAuthorizationToken and sts:GetServiceBearerToken

After the authentication works, we should also check whether it is still possible to build these Dockerfiles locally after these changes.

It's possible, I tried, you are subject to the unauthenticated rate limit, as dockerhub. This is discussed in the linked issue 👍

I see, ok :) Awesome.

A job failed! Check out the build log: (web) (plain)

info: removing cargo home
info: removing rustup binaries
info: rustup is uninstalled

usage: aws [options] <command> <subcommand> [<subcommand> ...] [parameters]
To see help text, you can run:
  aws help
  aws help
  aws <command> help
  aws <command> <subcommand> help
aws: error: the following arguments are required: value

##[error]Process completed with exit code 252.
Post job cleanup.

it might be that since I'm in a fork we can't use the secret to authenticate with aws?

☔ The latest upstream changes (presumably #133809) made this pull request unmergeable. Please resolve the merge conflicts.

☔ The latest upstream changes (presumably #134614) made this pull request unmergeable. Please resolve the merge conflicts.