Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use named pipe when creating new jobserver #71

Closed
NobodyXu opened this issue Mar 2, 2024 · 2 comments
Closed

use named pipe when creating new jobserver #71

NobodyXu opened this issue Mar 2, 2024 · 2 comments

Comments

@NobodyXu
Copy link
Contributor

NobodyXu commented Mar 2, 2024

Ref: rust-lang/cargo#13483 rust-lang/cc-rs#962

@NobodyXu
Copy link
Contributor Author

NobodyXu commented Mar 2, 2024

I propose that we should create named fifo instead of annoymous pipe by default, while retaining compatibility with older make by still passing the fds like this MAKEFLAGS='--jobserver-auth=fifo:/path/to/fifo --jobserver-fds=3,5'.

@NobodyXu
Copy link
Contributor Author

Unfortunately, --jobserver-auth is introduced in 4.2, but fifo jobserver and --jobserver-style is introduced in make 4.4

This means that if we use fifo we would break backwards compatibility, so closing this for now.

@NobodyXu NobodyXu closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant