Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin cc crate version on libc-test #1933

Closed
JohnTitor opened this issue Oct 17, 2020 · 0 comments · Fixed by #1954
Closed

Unpin cc crate version on libc-test #1933

JohnTitor opened this issue Oct 17, 2020 · 0 comments · Fixed by #1954
Labels
A-CI Area: CI-related items O-android

Comments

@JohnTitor
Copy link
Member

Previously, our Android jobs fail due to mismatching of API level somehow. After some debugging, it seems like rust-lang/cc-rs#495 is the cause. I pinned the cc crate version to 1.0.52 then the test passes as expected. For context: #1765 (comment)
But generally, it'd be great if we could use the latest version of the dependency. To unpin it, we should investigate more and introduce an actual fix to the cc crate.

@JohnTitor JohnTitor added A-CI Area: CI-related items O-android labels Oct 17, 2020
@bors bors closed this as completed in 80b3a51 Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: CI-related items O-android
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant