Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headings differing only in case are linked wrongly in search results #1579

Closed
simonmichael opened this issue Jun 15, 2021 · 2 comments
Closed

headings differing only in case are linked wrongly in search results #1579

simonmichael opened this issue Jun 15, 2021 · 2 comments
Labels
A-Search Area: Search E-Help-wanted Experience: Help Needed

Comments

@simonmichael
Copy link

simonmichael commented Jun 15, 2021 •
edited
Loading

badboy/mdbook-toc#16 seems to be an mdBook issue. At https://hledger.org/hledger.html I have "tags" and "Tags" sections. This is almost working now, except that in https://hledger.org/hledger.html?search=tags, both results link to the "tags" section. [The first result, "Tags", should link to https://hledger.org/hledger.html?highlight=tags#tags-1]

[cc simonmichael/hledger_site#33]
@ehuss ehuss added the A-Search Area: Search label Jul 6, 2021
@ehuss
Copy link
Contributor

ehuss commented Jul 6, 2021

This is mentioned in #720 (duplicate header names don't use the same logic). It would be nice if they could use the same code.

@ehuss ehuss added the E-Help-wanted Experience: Help Needed label Jul 6, 2021
@simonmichael simonmichael mentioned this issue Dec 7, 2021
Closed
@tommilligan tommilligan mentioned this issue Feb 18, 2022
Merged
@ehuss
Copy link
Contributor

ehuss commented Mar 28, 2022

Closing as resolved by #1749.

@ehuss ehuss closed this as completed Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Search Area: Search E-Help-wanted Experience: Help Needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonmichael @ehuss