From 651477276fde63ad12af4e6166b88eba536b3839 Mon Sep 17 00:00:00 2001 From: Ralf Jung Date: Fri, 21 Jul 2023 16:28:29 +0200 Subject: [PATCH] ask people to reach out if we declare too much UB --- src/diagnostics.rs | 4 ++-- tests/fail/both_borrows/alias_through_mutation.stack.stderr | 1 + tests/fail/both_borrows/aliasing_mut1.stack.stderr | 1 + tests/fail/both_borrows/aliasing_mut2.stack.stderr | 1 + tests/fail/both_borrows/aliasing_mut3.stack.stderr | 1 + tests/fail/both_borrows/aliasing_mut4.stack.stderr | 1 + tests/fail/both_borrows/box_exclusive_violation1.stack.stderr | 1 + tests/fail/both_borrows/box_noalias_violation.stack.stderr | 1 + tests/fail/both_borrows/buggy_as_mut_slice.stack.stderr | 1 + tests/fail/both_borrows/buggy_split_at_mut.stack.stderr | 1 + tests/fail/both_borrows/illegal_write1.stack.stderr | 1 + tests/fail/both_borrows/illegal_write5.stack.stderr | 1 + tests/fail/both_borrows/illegal_write6.stack.stderr | 1 + .../both_borrows/invalidate_against_protector2.stack.stderr | 1 + .../both_borrows/invalidate_against_protector3.stack.stderr | 1 + tests/fail/both_borrows/load_invalid_shr.stack.stderr | 1 + tests/fail/both_borrows/mut_exclusive_violation1.stack.stderr | 1 + tests/fail/both_borrows/mut_exclusive_violation2.stack.stderr | 1 + tests/fail/both_borrows/newtype_pair_retagging.stack.stderr | 1 + tests/fail/both_borrows/newtype_retagging.stack.stderr | 1 + tests/fail/both_borrows/outdated_local.stack.stderr | 1 + tests/fail/both_borrows/pass_invalid_shr.stack.stderr | 1 + tests/fail/both_borrows/pass_invalid_shr_option.stack.stderr | 1 + tests/fail/both_borrows/pass_invalid_shr_tuple.stack.stderr | 1 + tests/fail/both_borrows/return_invalid_shr.stack.stderr | 1 + .../fail/both_borrows/return_invalid_shr_option.stack.stderr | 1 + tests/fail/both_borrows/return_invalid_shr_tuple.stack.stderr | 1 + tests/fail/both_borrows/shr_frozen_violation1.stack.stderr | 1 + tests/fail/both_borrows/shr_frozen_violation2.stack.stderr | 1 + tests/fail/box-cell-alias.stderr | 1 + tests/fail/function_calls/arg_inplace_mutate.stack.stderr | 1 + .../function_calls/arg_inplace_observe_during.stack.stderr | 1 + .../fail/function_calls/return_pointer_aliasing.stack.stderr | 1 + .../fail/stacked_borrows/deallocate_against_protector1.stderr | 1 + .../stacked_borrows/disable_mut_does_not_merge_srw.stderr | 1 + tests/fail/stacked_borrows/drop_in_place_protector.stderr | 1 + tests/fail/stacked_borrows/drop_in_place_retag.stderr | 1 + tests/fail/stacked_borrows/exposed_only_ro.stderr | 1 + tests/fail/stacked_borrows/fnentry_invalidation.stderr | 1 + tests/fail/stacked_borrows/fnentry_invalidation2.stderr | 1 + tests/fail/stacked_borrows/illegal_dealloc1.stderr | 1 + tests/fail/stacked_borrows/illegal_read1.stderr | 1 + tests/fail/stacked_borrows/illegal_read2.stderr | 1 + tests/fail/stacked_borrows/illegal_read3.stderr | 1 + tests/fail/stacked_borrows/illegal_read4.stderr | 1 + tests/fail/stacked_borrows/illegal_read5.stderr | 1 + tests/fail/stacked_borrows/illegal_read6.stderr | 1 + tests/fail/stacked_borrows/illegal_read7.stderr | 1 + tests/fail/stacked_borrows/illegal_read8.stderr | 1 + .../fail/stacked_borrows/illegal_read_despite_exposed1.stderr | 1 + .../fail/stacked_borrows/illegal_read_despite_exposed2.stderr | 1 + tests/fail/stacked_borrows/illegal_write2.stderr | 1 + tests/fail/stacked_borrows/illegal_write3.stderr | 1 + tests/fail/stacked_borrows/illegal_write4.stderr | 1 + .../stacked_borrows/illegal_write_despite_exposed1.stderr | 1 + tests/fail/stacked_borrows/interior_mut1.stderr | 1 + tests/fail/stacked_borrows/interior_mut2.stderr | 1 + .../fail/stacked_borrows/invalidate_against_protector1.stderr | 1 + tests/fail/stacked_borrows/load_invalid_mut.stderr | 1 + tests/fail/stacked_borrows/pass_invalid_mut.stderr | 1 + tests/fail/stacked_borrows/pointer_smuggling.stderr | 1 + tests/fail/stacked_borrows/raw_tracking.stderr | 1 + tests/fail/stacked_borrows/return_invalid_mut.stderr | 1 + tests/fail/stacked_borrows/return_invalid_mut_option.stderr | 1 + tests/fail/stacked_borrows/return_invalid_mut_tuple.stderr | 1 + tests/fail/stacked_borrows/shared_rw_borrows_are_weak1.stderr | 1 + tests/fail/stacked_borrows/shared_rw_borrows_are_weak2.stderr | 1 + tests/fail/stacked_borrows/track_caller.stderr | 1 + tests/fail/stacked_borrows/transmute-is-no-escape.stderr | 1 + tests/fail/stacked_borrows/unescaped_local.stderr | 1 + tests/fail/stacked_borrows/unescaped_static.stderr | 1 + tests/fail/stacked_borrows/zst_slice.stderr | 1 + 72 files changed, 73 insertions(+), 2 deletions(-) diff --git a/src/diagnostics.rs b/src/diagnostics.rs index 2a06bd871e..80e49055c4 100644 --- a/src/diagnostics.rs +++ b/src/diagnostics.rs @@ -224,11 +224,11 @@ pub fn report_error<'tcx, 'mir>( (None, format!("or pass `-Zmiri-isolation-error=warn` to configure Miri to return an error code from isolated operations (if supported for that operation) and continue with a warning")), ], StackedBorrowsUb { help, history, .. } => { - let url = "https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md"; msg.extend(help.clone()); let mut helps = vec![ (None, format!("this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental")), - (None, format!("see {url} for further information")), + (None, format!("see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information")), + (None, format!("please reach out to us (e.g. at ) if you find this troubling")), ]; if let Some(TagHistory {created, invalidated, protected}) = history.clone() { helps.push((Some(created.1), created.0)); diff --git a/tests/fail/both_borrows/alias_through_mutation.stack.stderr b/tests/fail/both_borrows/alias_through_mutation.stack.stderr index b22db3eb12..144efc2f5e 100644 --- a/tests/fail/both_borrows/alias_through_mutation.stack.stderr +++ b/tests/fail/both_borrows/alias_through_mutation.stack.stderr @@ -9,6 +9,7 @@ LL | let _val = *target_alias; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/alias_through_mutation.rs:LL:CC | diff --git a/tests/fail/both_borrows/aliasing_mut1.stack.stderr b/tests/fail/both_borrows/aliasing_mut1.stack.stderr index 678211a700..0551453efc 100644 --- a/tests/fail/both_borrows/aliasing_mut1.stack.stderr +++ b/tests/fail/both_borrows/aliasing_mut1.stack.stderr @@ -6,6 +6,7 @@ LL | pub fn safe(x: &mut i32, y: &mut i32) { | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/aliasing_mut1.rs:LL:CC | diff --git a/tests/fail/both_borrows/aliasing_mut2.stack.stderr b/tests/fail/both_borrows/aliasing_mut2.stack.stderr index 90134ce367..a415bbd2e7 100644 --- a/tests/fail/both_borrows/aliasing_mut2.stack.stderr +++ b/tests/fail/both_borrows/aliasing_mut2.stack.stderr @@ -6,6 +6,7 @@ LL | pub fn safe(x: &i32, y: &mut i32) { | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/aliasing_mut2.rs:LL:CC | diff --git a/tests/fail/both_borrows/aliasing_mut3.stack.stderr b/tests/fail/both_borrows/aliasing_mut3.stack.stderr index a457bd9a6a..54decfd485 100644 --- a/tests/fail/both_borrows/aliasing_mut3.stack.stderr +++ b/tests/fail/both_borrows/aliasing_mut3.stack.stderr @@ -9,6 +9,7 @@ LL | pub fn safe(x: &mut i32, y: &i32) { | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/aliasing_mut3.rs:LL:CC | diff --git a/tests/fail/both_borrows/aliasing_mut4.stack.stderr b/tests/fail/both_borrows/aliasing_mut4.stack.stderr index b53ae9bd55..3744efb9ce 100644 --- a/tests/fail/both_borrows/aliasing_mut4.stack.stderr +++ b/tests/fail/both_borrows/aliasing_mut4.stack.stderr @@ -6,6 +6,7 @@ LL | pub fn safe(x: &i32, y: &mut Cell) { | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/aliasing_mut4.rs:LL:CC | diff --git a/tests/fail/both_borrows/box_exclusive_violation1.stack.stderr b/tests/fail/both_borrows/box_exclusive_violation1.stack.stderr index 76f4e81f71..58217be074 100644 --- a/tests/fail/both_borrows/box_exclusive_violation1.stack.stderr +++ b/tests/fail/both_borrows/box_exclusive_violation1.stack.stderr @@ -9,6 +9,7 @@ LL | *LEAK = 7; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/box_exclusive_violation1.rs:LL:CC | diff --git a/tests/fail/both_borrows/box_noalias_violation.stack.stderr b/tests/fail/both_borrows/box_noalias_violation.stack.stderr index 59377aeb97..9b0dbd23fa 100644 --- a/tests/fail/both_borrows/box_noalias_violation.stack.stderr +++ b/tests/fail/both_borrows/box_noalias_violation.stack.stderr @@ -6,6 +6,7 @@ LL | *y | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/box_noalias_violation.rs:LL:CC | diff --git a/tests/fail/both_borrows/buggy_as_mut_slice.stack.stderr b/tests/fail/both_borrows/buggy_as_mut_slice.stack.stderr index fa3d7ca367..63196386f1 100644 --- a/tests/fail/both_borrows/buggy_as_mut_slice.stack.stderr +++ b/tests/fail/both_borrows/buggy_as_mut_slice.stack.stderr @@ -9,6 +9,7 @@ LL | v1[1] = 5; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0xc] --> $DIR/buggy_as_mut_slice.rs:LL:CC | diff --git a/tests/fail/both_borrows/buggy_split_at_mut.stack.stderr b/tests/fail/both_borrows/buggy_split_at_mut.stack.stderr index b957464f95..975c07f1eb 100644 --- a/tests/fail/both_borrows/buggy_split_at_mut.stack.stderr +++ b/tests/fail/both_borrows/buggy_split_at_mut.stack.stderr @@ -12,6 +12,7 @@ LL | | ) | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x10] --> $DIR/buggy_split_at_mut.rs:LL:CC | diff --git a/tests/fail/both_borrows/illegal_write1.stack.stderr b/tests/fail/both_borrows/illegal_write1.stack.stderr index c1e4918146..43a12f4a18 100644 --- a/tests/fail/both_borrows/illegal_write1.stack.stderr +++ b/tests/fail/both_borrows/illegal_write1.stack.stderr @@ -9,6 +9,7 @@ LL | unsafe { *x = 42 }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/illegal_write1.rs:LL:CC | diff --git a/tests/fail/both_borrows/illegal_write5.stack.stderr b/tests/fail/both_borrows/illegal_write5.stack.stderr index c71780b7e0..3737853a8f 100644 --- a/tests/fail/both_borrows/illegal_write5.stack.stderr +++ b/tests/fail/both_borrows/illegal_write5.stack.stderr @@ -9,6 +9,7 @@ LL | let _val = *xref; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/illegal_write5.rs:LL:CC | diff --git a/tests/fail/both_borrows/illegal_write6.stack.stderr b/tests/fail/both_borrows/illegal_write6.stack.stderr index 3d3d2a24c2..bc7425e279 100644 --- a/tests/fail/both_borrows/illegal_write6.stack.stderr +++ b/tests/fail/both_borrows/illegal_write6.stack.stderr @@ -6,6 +6,7 @@ LL | unsafe { *y = 2 }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/illegal_write6.rs:LL:CC | diff --git a/tests/fail/both_borrows/invalidate_against_protector2.stack.stderr b/tests/fail/both_borrows/invalidate_against_protector2.stack.stderr index 8f677bd547..9f2966c13f 100644 --- a/tests/fail/both_borrows/invalidate_against_protector2.stack.stderr +++ b/tests/fail/both_borrows/invalidate_against_protector2.stack.stderr @@ -6,6 +6,7 @@ LL | unsafe { *x = 0 }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/invalidate_against_protector2.rs:LL:CC | diff --git a/tests/fail/both_borrows/invalidate_against_protector3.stack.stderr b/tests/fail/both_borrows/invalidate_against_protector3.stack.stderr index 1648ca9e58..da13262c76 100644 --- a/tests/fail/both_borrows/invalidate_against_protector3.stack.stderr +++ b/tests/fail/both_borrows/invalidate_against_protector3.stack.stderr @@ -6,6 +6,7 @@ LL | unsafe { *x = 0 }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created here, as the base tag for ALLOC --> $DIR/invalidate_against_protector3.rs:LL:CC | diff --git a/tests/fail/both_borrows/load_invalid_shr.stack.stderr b/tests/fail/both_borrows/load_invalid_shr.stack.stderr index 7eb973ae7f..ee5561268d 100644 --- a/tests/fail/both_borrows/load_invalid_shr.stack.stderr +++ b/tests/fail/both_borrows/load_invalid_shr.stack.stderr @@ -9,6 +9,7 @@ LL | let _val = *xref_in_mem; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/load_invalid_shr.rs:LL:CC | diff --git a/tests/fail/both_borrows/mut_exclusive_violation1.stack.stderr b/tests/fail/both_borrows/mut_exclusive_violation1.stack.stderr index 3e7fe11b52..62a8e6a04b 100644 --- a/tests/fail/both_borrows/mut_exclusive_violation1.stack.stderr +++ b/tests/fail/both_borrows/mut_exclusive_violation1.stack.stderr @@ -9,6 +9,7 @@ LL | *LEAK = 7; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/mut_exclusive_violation1.rs:LL:CC | diff --git a/tests/fail/both_borrows/mut_exclusive_violation2.stack.stderr b/tests/fail/both_borrows/mut_exclusive_violation2.stack.stderr index 258189f887..4fbcaee0aa 100644 --- a/tests/fail/both_borrows/mut_exclusive_violation2.stack.stderr +++ b/tests/fail/both_borrows/mut_exclusive_violation2.stack.stderr @@ -9,6 +9,7 @@ LL | let _val = *raw1; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/mut_exclusive_violation2.rs:LL:CC | diff --git a/tests/fail/both_borrows/newtype_pair_retagging.stack.stderr b/tests/fail/both_borrows/newtype_pair_retagging.stack.stderr index 0cba380ea1..d9f5e9ad47 100644 --- a/tests/fail/both_borrows/newtype_pair_retagging.stack.stderr +++ b/tests/fail/both_borrows/newtype_pair_retagging.stack.stderr @@ -6,6 +6,7 @@ LL | Box(unsafe { Unique::new_unchecked(raw) }, alloc) | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/newtype_pair_retagging.rs:LL:CC | diff --git a/tests/fail/both_borrows/newtype_retagging.stack.stderr b/tests/fail/both_borrows/newtype_retagging.stack.stderr index f76b6a57ea..9335b27fb1 100644 --- a/tests/fail/both_borrows/newtype_retagging.stack.stderr +++ b/tests/fail/both_borrows/newtype_retagging.stack.stderr @@ -6,6 +6,7 @@ LL | Box(unsafe { Unique::new_unchecked(raw) }, alloc) | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/newtype_retagging.rs:LL:CC | diff --git a/tests/fail/both_borrows/outdated_local.stack.stderr b/tests/fail/both_borrows/outdated_local.stack.stderr index ad366bdabc..91861b8066 100644 --- a/tests/fail/both_borrows/outdated_local.stack.stderr +++ b/tests/fail/both_borrows/outdated_local.stack.stderr @@ -9,6 +9,7 @@ LL | assert_eq!(unsafe { *y }, 1); | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/outdated_local.rs:LL:CC | diff --git a/tests/fail/both_borrows/pass_invalid_shr.stack.stderr b/tests/fail/both_borrows/pass_invalid_shr.stack.stderr index 5243858a91..424b3ba7ea 100644 --- a/tests/fail/both_borrows/pass_invalid_shr.stack.stderr +++ b/tests/fail/both_borrows/pass_invalid_shr.stack.stderr @@ -9,6 +9,7 @@ LL | foo(xref); | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/pass_invalid_shr.rs:LL:CC | diff --git a/tests/fail/both_borrows/pass_invalid_shr_option.stack.stderr b/tests/fail/both_borrows/pass_invalid_shr_option.stack.stderr index 96121f0659..78096c75f8 100644 --- a/tests/fail/both_borrows/pass_invalid_shr_option.stack.stderr +++ b/tests/fail/both_borrows/pass_invalid_shr_option.stack.stderr @@ -9,6 +9,7 @@ LL | foo(some_xref); | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/pass_invalid_shr_option.rs:LL:CC | diff --git a/tests/fail/both_borrows/pass_invalid_shr_tuple.stack.stderr b/tests/fail/both_borrows/pass_invalid_shr_tuple.stack.stderr index 0cfaf12355..ce982d13f6 100644 --- a/tests/fail/both_borrows/pass_invalid_shr_tuple.stack.stderr +++ b/tests/fail/both_borrows/pass_invalid_shr_tuple.stack.stderr @@ -9,6 +9,7 @@ LL | foo(pair_xref); | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/pass_invalid_shr_tuple.rs:LL:CC | diff --git a/tests/fail/both_borrows/return_invalid_shr.stack.stderr b/tests/fail/both_borrows/return_invalid_shr.stack.stderr index d3a73a00fa..32ff5c0c88 100644 --- a/tests/fail/both_borrows/return_invalid_shr.stack.stderr +++ b/tests/fail/both_borrows/return_invalid_shr.stack.stderr @@ -9,6 +9,7 @@ LL | ret | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x4..0x8] --> $DIR/return_invalid_shr.rs:LL:CC | diff --git a/tests/fail/both_borrows/return_invalid_shr_option.stack.stderr b/tests/fail/both_borrows/return_invalid_shr_option.stack.stderr index d5b8433568..702bd71dc1 100644 --- a/tests/fail/both_borrows/return_invalid_shr_option.stack.stderr +++ b/tests/fail/both_borrows/return_invalid_shr_option.stack.stderr @@ -9,6 +9,7 @@ LL | ret | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x4..0x8] --> $DIR/return_invalid_shr_option.rs:LL:CC | diff --git a/tests/fail/both_borrows/return_invalid_shr_tuple.stack.stderr b/tests/fail/both_borrows/return_invalid_shr_tuple.stack.stderr index 9ced0da96c..4bef3fa5db 100644 --- a/tests/fail/both_borrows/return_invalid_shr_tuple.stack.stderr +++ b/tests/fail/both_borrows/return_invalid_shr_tuple.stack.stderr @@ -9,6 +9,7 @@ LL | ret | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x4..0x8] --> $DIR/return_invalid_shr_tuple.rs:LL:CC | diff --git a/tests/fail/both_borrows/shr_frozen_violation1.stack.stderr b/tests/fail/both_borrows/shr_frozen_violation1.stack.stderr index a69116f2af..f9ba2941ec 100644 --- a/tests/fail/both_borrows/shr_frozen_violation1.stack.stderr +++ b/tests/fail/both_borrows/shr_frozen_violation1.stack.stderr @@ -9,6 +9,7 @@ LL | *(x as *const i32 as *mut i32) = 7; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/shr_frozen_violation1.rs:LL:CC | diff --git a/tests/fail/both_borrows/shr_frozen_violation2.stack.stderr b/tests/fail/both_borrows/shr_frozen_violation2.stack.stderr index 0f09359007..b8e41652d4 100644 --- a/tests/fail/both_borrows/shr_frozen_violation2.stack.stderr +++ b/tests/fail/both_borrows/shr_frozen_violation2.stack.stderr @@ -9,6 +9,7 @@ LL | let _val = *frozen; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/shr_frozen_violation2.rs:LL:CC | diff --git a/tests/fail/box-cell-alias.stderr b/tests/fail/box-cell-alias.stderr index 8c68261aaf..057357ea66 100644 --- a/tests/fail/box-cell-alias.stderr +++ b/tests/fail/box-cell-alias.stderr @@ -9,6 +9,7 @@ LL | unsafe { (*ptr).set(20) }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x1] --> $DIR/box-cell-alias.rs:LL:CC | diff --git a/tests/fail/function_calls/arg_inplace_mutate.stack.stderr b/tests/fail/function_calls/arg_inplace_mutate.stack.stderr index 471dc1dd6d..04ee8c6aa9 100644 --- a/tests/fail/function_calls/arg_inplace_mutate.stack.stderr +++ b/tests/fail/function_calls/arg_inplace_mutate.stack.stderr @@ -6,6 +6,7 @@ LL | unsafe { ptr.write(S(0)) }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/arg_inplace_mutate.rs:LL:CC | diff --git a/tests/fail/function_calls/arg_inplace_observe_during.stack.stderr b/tests/fail/function_calls/arg_inplace_observe_during.stack.stderr index a842d3a804..2615a61a19 100644 --- a/tests/fail/function_calls/arg_inplace_observe_during.stack.stderr +++ b/tests/fail/function_calls/arg_inplace_observe_during.stack.stderr @@ -6,6 +6,7 @@ LL | unsafe { ptr.read() }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/arg_inplace_observe_during.rs:LL:CC | diff --git a/tests/fail/function_calls/return_pointer_aliasing.stack.stderr b/tests/fail/function_calls/return_pointer_aliasing.stack.stderr index d486dcb95d..ad90d835ee 100644 --- a/tests/fail/function_calls/return_pointer_aliasing.stack.stderr +++ b/tests/fail/function_calls/return_pointer_aliasing.stack.stderr @@ -6,6 +6,7 @@ LL | unsafe { ptr.read() }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/return_pointer_aliasing.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/deallocate_against_protector1.stderr b/tests/fail/stacked_borrows/deallocate_against_protector1.stderr index 8ebb35450e..ddf2d7a093 100644 --- a/tests/fail/stacked_borrows/deallocate_against_protector1.stderr +++ b/tests/fail/stacked_borrows/deallocate_against_protector1.stderr @@ -6,6 +6,7 @@ LL | unsafe { __rust_dealloc(ptr, layout.size(), layout.align()) } | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling = note: BACKTRACE: = note: inside `std::alloc::dealloc` at RUSTLIB/alloc/src/alloc.rs:LL:CC = note: inside `::deallocate` at RUSTLIB/alloc/src/alloc.rs:LL:CC diff --git a/tests/fail/stacked_borrows/disable_mut_does_not_merge_srw.stderr b/tests/fail/stacked_borrows/disable_mut_does_not_merge_srw.stderr index bd79b401f6..42c7c257e0 100644 --- a/tests/fail/stacked_borrows/disable_mut_does_not_merge_srw.stderr +++ b/tests/fail/stacked_borrows/disable_mut_does_not_merge_srw.stderr @@ -9,6 +9,7 @@ LL | let _val = *raw; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/disable_mut_does_not_merge_srw.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/drop_in_place_protector.stderr b/tests/fail/stacked_borrows/drop_in_place_protector.stderr index 3d0cef241c..989051ae36 100644 --- a/tests/fail/stacked_borrows/drop_in_place_protector.stderr +++ b/tests/fail/stacked_borrows/drop_in_place_protector.stderr @@ -6,6 +6,7 @@ LL | let _val = *P; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x1] --> $DIR/drop_in_place_protector.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/drop_in_place_retag.stderr b/tests/fail/stacked_borrows/drop_in_place_retag.stderr index 7f2917e795..3ce18e0dd3 100644 --- a/tests/fail/stacked_borrows/drop_in_place_retag.stderr +++ b/tests/fail/stacked_borrows/drop_in_place_retag.stderr @@ -9,6 +9,7 @@ LL | pub unsafe fn drop_in_place(to_drop: *mut T) { | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x1] --> $DIR/drop_in_place_retag.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/exposed_only_ro.stderr b/tests/fail/stacked_borrows/exposed_only_ro.stderr index cb5e7bffde..54bd1f3ff1 100644 --- a/tests/fail/stacked_borrows/exposed_only_ro.stderr +++ b/tests/fail/stacked_borrows/exposed_only_ro.stderr @@ -9,6 +9,7 @@ LL | unsafe { *ptr = 0 }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling = note: BACKTRACE: = note: inside `main` at $DIR/exposed_only_ro.rs:LL:CC diff --git a/tests/fail/stacked_borrows/fnentry_invalidation.stderr b/tests/fail/stacked_borrows/fnentry_invalidation.stderr index 236c8fb018..b6e83938cd 100644 --- a/tests/fail/stacked_borrows/fnentry_invalidation.stderr +++ b/tests/fail/stacked_borrows/fnentry_invalidation.stderr @@ -9,6 +9,7 @@ LL | let _oof = *z; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/fnentry_invalidation.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/fnentry_invalidation2.stderr b/tests/fail/stacked_borrows/fnentry_invalidation2.stderr index 45c2197050..746605864c 100644 --- a/tests/fail/stacked_borrows/fnentry_invalidation2.stderr +++ b/tests/fail/stacked_borrows/fnentry_invalidation2.stderr @@ -9,6 +9,7 @@ LL | let _oof = *ptr; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0xc] --> $DIR/fnentry_invalidation2.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_dealloc1.stderr b/tests/fail/stacked_borrows/illegal_dealloc1.stderr index 7fff60f25f..caad364f5c 100644 --- a/tests/fail/stacked_borrows/illegal_dealloc1.stderr +++ b/tests/fail/stacked_borrows/illegal_dealloc1.stderr @@ -6,6 +6,7 @@ LL | unsafe { __rust_dealloc(ptr, layout.size(), layout.align()) } | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x1] --> $DIR/illegal_deALLOC.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_read1.stderr b/tests/fail/stacked_borrows/illegal_read1.stderr index 7a159c9d3f..8dc817f3f6 100644 --- a/tests/fail/stacked_borrows/illegal_read1.stderr +++ b/tests/fail/stacked_borrows/illegal_read1.stderr @@ -9,6 +9,7 @@ LL | let _val = *xref; // ...but any use of raw will invalidate our ref. | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/illegal_read1.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_read2.stderr b/tests/fail/stacked_borrows/illegal_read2.stderr index e3e79f6f0f..ac9cf0d352 100644 --- a/tests/fail/stacked_borrows/illegal_read2.stderr +++ b/tests/fail/stacked_borrows/illegal_read2.stderr @@ -9,6 +9,7 @@ LL | let _val = *xref; // ...but any use of raw will invalidate our ref. | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/illegal_read2.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_read3.stderr b/tests/fail/stacked_borrows/illegal_read3.stderr index 3a8687ad9a..b1aa53794d 100644 --- a/tests/fail/stacked_borrows/illegal_read3.stderr +++ b/tests/fail/stacked_borrows/illegal_read3.stderr @@ -9,6 +9,7 @@ LL | let _val = *xref2; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/illegal_read3.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_read4.stderr b/tests/fail/stacked_borrows/illegal_read4.stderr index dcf37b2690..41c5361cc9 100644 --- a/tests/fail/stacked_borrows/illegal_read4.stderr +++ b/tests/fail/stacked_borrows/illegal_read4.stderr @@ -9,6 +9,7 @@ LL | let _illegal = *xref2; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/illegal_read4.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_read5.stderr b/tests/fail/stacked_borrows/illegal_read5.stderr index 1793798d15..63293e1fc0 100644 --- a/tests/fail/stacked_borrows/illegal_read5.stderr +++ b/tests/fail/stacked_borrows/illegal_read5.stderr @@ -9,6 +9,7 @@ LL | let _val = *xref; // the mutable one is dead and gone | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [$HEX..$HEX] --> $DIR/illegal_read5.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_read6.stderr b/tests/fail/stacked_borrows/illegal_read6.stderr index 17b28dee3c..688d8e7e98 100644 --- a/tests/fail/stacked_borrows/illegal_read6.stderr +++ b/tests/fail/stacked_borrows/illegal_read6.stderr @@ -9,6 +9,7 @@ LL | let _val = *raw; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/illegal_read6.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_read7.stderr b/tests/fail/stacked_borrows/illegal_read7.stderr index 1a9d551431..938010b24a 100644 --- a/tests/fail/stacked_borrows/illegal_read7.stderr +++ b/tests/fail/stacked_borrows/illegal_read7.stderr @@ -9,6 +9,7 @@ LL | let _val = *x.get_mut(); | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/illegal_read7.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_read8.stderr b/tests/fail/stacked_borrows/illegal_read8.stderr index b43079c3b7..01dc7f3e16 100644 --- a/tests/fail/stacked_borrows/illegal_read8.stderr +++ b/tests/fail/stacked_borrows/illegal_read8.stderr @@ -9,6 +9,7 @@ LL | let _fail = *y1; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/illegal_read8.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_read_despite_exposed1.stderr b/tests/fail/stacked_borrows/illegal_read_despite_exposed1.stderr index fbd5d8b956..d0d835d55a 100644 --- a/tests/fail/stacked_borrows/illegal_read_despite_exposed1.stderr +++ b/tests/fail/stacked_borrows/illegal_read_despite_exposed1.stderr @@ -9,6 +9,7 @@ LL | let _val = *root2; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/illegal_read_despite_exposed1.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_read_despite_exposed2.stderr b/tests/fail/stacked_borrows/illegal_read_despite_exposed2.stderr index 19e4cbdb93..12cc022c3b 100644 --- a/tests/fail/stacked_borrows/illegal_read_despite_exposed2.stderr +++ b/tests/fail/stacked_borrows/illegal_read_despite_exposed2.stderr @@ -9,6 +9,7 @@ LL | let _val = *root2; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/illegal_read_despite_exposed2.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_write2.stderr b/tests/fail/stacked_borrows/illegal_write2.stderr index 3e11e86eb8..7fa6afeb7d 100644 --- a/tests/fail/stacked_borrows/illegal_write2.stderr +++ b/tests/fail/stacked_borrows/illegal_write2.stderr @@ -9,6 +9,7 @@ LL | unsafe { *target2 = 13 }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/illegal_write2.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_write3.stderr b/tests/fail/stacked_borrows/illegal_write3.stderr index 4053325821..1c22c01f52 100644 --- a/tests/fail/stacked_borrows/illegal_write3.stderr +++ b/tests/fail/stacked_borrows/illegal_write3.stderr @@ -9,6 +9,7 @@ LL | unsafe { *ptr = 42 }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/illegal_write3.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_write4.stderr b/tests/fail/stacked_borrows/illegal_write4.stderr index fceda8db4c..693ec50fcb 100644 --- a/tests/fail/stacked_borrows/illegal_write4.stderr +++ b/tests/fail/stacked_borrows/illegal_write4.stderr @@ -9,6 +9,7 @@ LL | let _val = *reference; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/illegal_write4.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/illegal_write_despite_exposed1.stderr b/tests/fail/stacked_borrows/illegal_write_despite_exposed1.stderr index 1bb3afe483..d6ed8ff9f2 100644 --- a/tests/fail/stacked_borrows/illegal_write_despite_exposed1.stderr +++ b/tests/fail/stacked_borrows/illegal_write_despite_exposed1.stderr @@ -9,6 +9,7 @@ LL | let _val = *root2; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x4] --> $DIR/illegal_write_despite_exposed1.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/interior_mut1.stderr b/tests/fail/stacked_borrows/interior_mut1.stderr index ba8977c567..49b56541be 100644 --- a/tests/fail/stacked_borrows/interior_mut1.stderr +++ b/tests/fail/stacked_borrows/interior_mut1.stderr @@ -9,6 +9,7 @@ LL | let _val = *inner_shr.get(); | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/interior_mut1.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/interior_mut2.stderr b/tests/fail/stacked_borrows/interior_mut2.stderr index 97ebe72bf2..a6024a07e1 100644 --- a/tests/fail/stacked_borrows/interior_mut2.stderr +++ b/tests/fail/stacked_borrows/interior_mut2.stderr @@ -9,6 +9,7 @@ LL | let _val = *inner_shr.get(); | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/interior_mut2.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/invalidate_against_protector1.stderr b/tests/fail/stacked_borrows/invalidate_against_protector1.stderr index 95fa4c51d1..1ccb5a97b1 100644 --- a/tests/fail/stacked_borrows/invalidate_against_protector1.stderr +++ b/tests/fail/stacked_borrows/invalidate_against_protector1.stderr @@ -6,6 +6,7 @@ LL | let _val = unsafe { *x }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/invalidate_against_protector1.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/load_invalid_mut.stderr b/tests/fail/stacked_borrows/load_invalid_mut.stderr index 7aca065ca0..311c37f2d0 100644 --- a/tests/fail/stacked_borrows/load_invalid_mut.stderr +++ b/tests/fail/stacked_borrows/load_invalid_mut.stderr @@ -9,6 +9,7 @@ LL | let _val = *xref_in_mem; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/load_invalid_mut.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/pass_invalid_mut.stderr b/tests/fail/stacked_borrows/pass_invalid_mut.stderr index 96cec327b9..6521868987 100644 --- a/tests/fail/stacked_borrows/pass_invalid_mut.stderr +++ b/tests/fail/stacked_borrows/pass_invalid_mut.stderr @@ -9,6 +9,7 @@ LL | foo(xref); | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/pass_invalid_mut.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/pointer_smuggling.stderr b/tests/fail/stacked_borrows/pointer_smuggling.stderr index e20b5b89a2..2e03b46610 100644 --- a/tests/fail/stacked_borrows/pointer_smuggling.stderr +++ b/tests/fail/stacked_borrows/pointer_smuggling.stderr @@ -9,6 +9,7 @@ LL | let _x = unsafe { *PTR }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x1] --> $DIR/pointer_smuggling.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/raw_tracking.stderr b/tests/fail/stacked_borrows/raw_tracking.stderr index 9f7e7a058d..4afb15c781 100644 --- a/tests/fail/stacked_borrows/raw_tracking.stderr +++ b/tests/fail/stacked_borrows/raw_tracking.stderr @@ -9,6 +9,7 @@ LL | unsafe { *raw1 = 13 }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x0..0x4] --> $DIR/raw_tracking.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/return_invalid_mut.stderr b/tests/fail/stacked_borrows/return_invalid_mut.stderr index 2bf91b676c..dea2b89ece 100644 --- a/tests/fail/stacked_borrows/return_invalid_mut.stderr +++ b/tests/fail/stacked_borrows/return_invalid_mut.stderr @@ -9,6 +9,7 @@ LL | ret | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x4..0x8] --> $DIR/return_invalid_mut.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/return_invalid_mut_option.stderr b/tests/fail/stacked_borrows/return_invalid_mut_option.stderr index 89b6cee7d9..1a0b67de37 100644 --- a/tests/fail/stacked_borrows/return_invalid_mut_option.stderr +++ b/tests/fail/stacked_borrows/return_invalid_mut_option.stderr @@ -9,6 +9,7 @@ LL | ret | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x4..0x8] --> $DIR/return_invalid_mut_option.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/return_invalid_mut_tuple.stderr b/tests/fail/stacked_borrows/return_invalid_mut_tuple.stderr index 388b00c714..80add1805b 100644 --- a/tests/fail/stacked_borrows/return_invalid_mut_tuple.stderr +++ b/tests/fail/stacked_borrows/return_invalid_mut_tuple.stderr @@ -9,6 +9,7 @@ LL | ret | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x4..0x8] --> $DIR/return_invalid_mut_tuple.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/shared_rw_borrows_are_weak1.stderr b/tests/fail/stacked_borrows/shared_rw_borrows_are_weak1.stderr index 10f97180b7..2ec61a777b 100644 --- a/tests/fail/stacked_borrows/shared_rw_borrows_are_weak1.stderr +++ b/tests/fail/stacked_borrows/shared_rw_borrows_are_weak1.stderr @@ -9,6 +9,7 @@ LL | y.get_mut(); | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/shared_rw_borrows_are_weak1.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/shared_rw_borrows_are_weak2.stderr b/tests/fail/stacked_borrows/shared_rw_borrows_are_weak2.stderr index 0e37c4ffb3..5f8182d0e7 100644 --- a/tests/fail/stacked_borrows/shared_rw_borrows_are_weak2.stderr +++ b/tests/fail/stacked_borrows/shared_rw_borrows_are_weak2.stderr @@ -9,6 +9,7 @@ LL | let _val = *y; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [$HEX..$HEX] --> $DIR/shared_rw_borrows_are_weak2.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/track_caller.stderr b/tests/fail/stacked_borrows/track_caller.stderr index 05be0d3f1e..b09e2b137b 100644 --- a/tests/fail/stacked_borrows/track_caller.stderr +++ b/tests/fail/stacked_borrows/track_caller.stderr @@ -9,6 +9,7 @@ LL | let _val = *xref; // ...but any use of raw will invalidate our ref. | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a Unique retag at offsets [0x0..0x4] --> $DIR/track_caller.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/transmute-is-no-escape.stderr b/tests/fail/stacked_borrows/transmute-is-no-escape.stderr index ac962311d4..2a678b9a10 100644 --- a/tests/fail/stacked_borrows/transmute-is-no-escape.stderr +++ b/tests/fail/stacked_borrows/transmute-is-no-escape.stderr @@ -9,6 +9,7 @@ LL | unsafe { *raw = 13 }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadWrite retag at offsets [0x4..0x8] --> $DIR/transmute-is-no-escape.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/unescaped_local.stderr b/tests/fail/stacked_borrows/unescaped_local.stderr index 4deafa8900..099481e306 100644 --- a/tests/fail/stacked_borrows/unescaped_local.stderr +++ b/tests/fail/stacked_borrows/unescaped_local.stderr @@ -9,6 +9,7 @@ LL | *raw = 13; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling = note: BACKTRACE: = note: inside `main` at $DIR/unescaped_local.rs:LL:CC diff --git a/tests/fail/stacked_borrows/unescaped_static.stderr b/tests/fail/stacked_borrows/unescaped_static.stderr index 7a40d1078b..028ca04a55 100644 --- a/tests/fail/stacked_borrows/unescaped_static.stderr +++ b/tests/fail/stacked_borrows/unescaped_static.stderr @@ -9,6 +9,7 @@ LL | let _val = unsafe { *ptr_to_first.add(1) }; | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: was created by a SharedReadOnly retag at offsets [0x0..0x1] --> $DIR/unescaped_static.rs:LL:CC | diff --git a/tests/fail/stacked_borrows/zst_slice.stderr b/tests/fail/stacked_borrows/zst_slice.stderr index 950abc4cbc..478b423d22 100644 --- a/tests/fail/stacked_borrows/zst_slice.stderr +++ b/tests/fail/stacked_borrows/zst_slice.stderr @@ -9,6 +9,7 @@ LL | unsafe { &*index.get_unchecked(self) } | = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information + = help: please reach out to us (e.g. at ) if you find this troubling help: would have been created here, but this is a zero-size retag ([0x0..0x0]) so the tag in question does not exist anywhere --> $DIR/zst_slice.rs:LL:CC |