Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to run a polonius check on my code #154

Open
Plecra opened this issue Aug 19, 2020 · 1 comment
Open

Attempting to run a polonius check on my code #154

Plecra opened this issue Aug 19, 2020 · 1 comment

Comments

@Plecra
Copy link

Plecra commented Aug 19, 2020

I was a little disappointed when this StreamingIterator implementation wouldn't compile. The complaint it had about lifetimes didn't seem to make sense to me, and brought Polonius to mind.

I'm not very familiar with the project, but I tried to run polonius on the the code's facts:

Directory: .\inputs\streaming-iterator.rs\nll-facts\{{impl}}-next\
Time: 0.024s
# errors
# move_errors
# subset_errors

Do I get to be excited?

@lqd
Copy link
Member

lqd commented Aug 21, 2020

Probably best to be a bit cautious at first: Polonius is still work-in-progress, it doesn't handle all the possible errors it needs to just yet. For example, there are also other patterns which seem likely to interact with GATs and will require integration with Chalk inside rustc, and this work is still in the design phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants