-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undocumented Attributes #532
Comments
|
What does the attribute do? @petrochenkov Could you try a PR + crater to "destabilization"?
👍
👍 + note that it is unstable.
What... @petrochenkov I'd also attempt destabilization for this...
Sounds good.
@ehuss I think these PRs haven't received any attention for some time, if you would like to take over them that'd be nice. |
Hm, looking closer, I'm not sure. rustdoc used to use it to separate automatically derived traits, but it was removed in rust-lang/rust#34105. Just grepping through the code shows a few uses:
Here's a sampling of crates that use it in the wild:
Yea, I'll try to take a look. I think Jorge said he's busy with thesis work. |
That sounds concerning...
Oh... wow; That seems quite unfortunate... Might be unfeasible to destabilize, maybe we should try to clarify semantics instead then... |
Here it is used to display a warning diagnostic if |
This can be closed, yes? |
Yea. I seem to recall leaving it open for some reason, but now I can't remember. |
There are a few attributes that are currently not documented. I wanted to get feedback if these should be documented. I've included my inclination, but I'd like to hear what others think.
automatically_derived
— I vote "probably"? It has some use in the wild. I think the only reason to use it is for rustdoc. Are there other reasons to use it?feature
— I vote "maybe" 🤔? Although this is a nightly-oriented attribute, it is very widely used.type_length_limit
— I vote "yes". I think it is analogous torecursion_limit
, and I suspect it just fell through the cracks.bench
— I vote "no". It requires the unstableBencher
to be used. (Now destabilized via Remove derivesEncodable
/Decodable
and unstabilize attribute#[bench]
rust#62507)reexport_test_harness_main
— I vote "no". Even though it is usable on stable, I think it is an internal implementation detail, and I do not see anyone using it.These are just waiting to be finished:
panic_handler
(document #[panic_handler] #362)used
(document #[used] #361)target_feature
(target_feature (RFC 2045, RFC 2325) #286)The text was updated successfully, but these errors were encountered: