-
Notifications
You must be signed in to change notification settings - Fork 456
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: rust-lang/regex
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.7.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: rust-lang/regex
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.7.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 8 commits
- 7 files changed
- 1 contributor
Commits on Mar 21, 2023
-
syntax: tweak the "no stack overflow" test
This test works by spinning up a thread with an atypically small stack size, parsing a regex into an Ast and then dropping it. We use a small stack size such that *if the Ast didn't have a custom Drop impl*, then its default recursive Drop impl would overflow the stack. (If we don't use a smaller stack size, then the default on some platforms is usually quite large and might require a much larger Ast to provoke a failure.) It turns out that the stack size we were using was quite tiny, and too tiny for some platforms such as FreeBSD. We therefore increase it a little bit, but not too much. We do the same for the corresponding test for the custom Drop impl for Hir. Fixes #967
Configuration menu - View commit details
-
Copy full SHA for d8e22dd - Browse repository at this point
Copy the full SHA d8e22ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48b3ba4 - Browse repository at this point
Copy the full SHA 48b3ba4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72d482f - Browse repository at this point
Copy the full SHA 72d482fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a7ba1e - Browse repository at this point
Copy the full SHA 6a7ba1eView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 32fed94 - Browse repository at this point
Copy the full SHA 32fed94View commit details
Commits on Mar 25, 2023
-
dfa: fix bug in how the reverse DFA is called
In turns out that in *some* calls to Fsm::reverse, we were passing an incorrect start offset. Namely, the haystack we pass is sub-sliced at `&text[start..]`, but in some places, we were passing `text.len()` as the start offset of the reverse search. But of course, it should be `text.len() - start`. This was indeed the case in most places, but it looks like it needed to be corrected in two additional places. I've also added this test to regex-automata's set of regression tests and can confirm that it doesn't happen there. (regex-automata is far more principled about handling offsets like this.) Fixes #969
Configuration menu - View commit details
-
Copy full SHA for d94f955 - Browse repository at this point
Copy the full SHA d94f955View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9562ccd - Browse repository at this point
Copy the full SHA 9562ccdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9582040 - Browse repository at this point
Copy the full SHA 9582040View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.7.1...1.7.3