Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/regex
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.7.1
Choose a base ref
...
head repository: rust-lang/regex
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.7.3
Choose a head ref
  • 8 commits
  • 7 files changed
  • 1 contributor

Commits on Mar 21, 2023

  1. syntax: tweak the "no stack overflow" test

    This test works by spinning up a thread with an atypically small stack
    size, parsing a regex into an Ast and then dropping it. We use a small
    stack size such that *if the Ast didn't have a custom Drop impl*, then
    its default recursive Drop impl would overflow the stack. (If we don't
    use a smaller stack size, then the default on some platforms is usually
    quite large and might require a much larger Ast to provoke a failure.)
    
    It turns out that the stack size we were using was quite tiny, and too
    tiny for some platforms such as FreeBSD. We therefore increase it a
    little bit, but not too much.
    
    We do the same for the corresponding test for the custom Drop impl for
    Hir.
    
    Fixes #967
    BurntSushi committed Mar 21, 2023

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    zalegrala Zach Leslie
    Copy the full SHA
    d8e22dd View commit details
  2. changelog: 1.7.2

    BurntSushi committed Mar 21, 2023

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    zalegrala Zach Leslie
    Copy the full SHA
    48b3ba4 View commit details
  3. regex-syntax-0.6.29

    BurntSushi committed Mar 21, 2023

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    zalegrala Zach Leslie
    Copy the full SHA
    72d482f View commit details
  4. Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    zalegrala Zach Leslie
    Copy the full SHA
    6a7ba1e View commit details
  5. 1.7.2

    BurntSushi committed Mar 21, 2023
    1

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    zalegrala Zach Leslie
    Copy the full SHA
    32fed94 View commit details

Commits on Mar 25, 2023

  1. dfa: fix bug in how the reverse DFA is called

    In turns out that in *some* calls to Fsm::reverse, we were passing an
    incorrect start offset. Namely, the haystack we pass is sub-sliced at
    `&text[start..]`, but in some places, we were passing `text.len()` as
    the start offset of the reverse search. But of course, it should be
    `text.len() - start`. This was indeed the case in most places, but it
    looks like it needed to be corrected in two additional places.
    
    I've also added this test to regex-automata's set of regression tests
    and can confirm that it doesn't happen there. (regex-automata is far
    more principled about handling offsets like this.)
    
    Fixes #969
    BurntSushi committed Mar 25, 2023

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    zalegrala Zach Leslie
    Copy the full SHA
    d94f955 View commit details
  2. changelog: 1.7.3

    BurntSushi committed Mar 25, 2023

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    zalegrala Zach Leslie
    Copy the full SHA
    9562ccd View commit details
  3. 1.7.3

    BurntSushi committed Mar 25, 2023

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    zalegrala Zach Leslie
    Copy the full SHA
    9582040 View commit details
Loading