Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to migrate off of ring #261

Closed
anp opened this issue Jan 28, 2019 · 6 comments
Closed

Find a way to migrate off of ring #261

anp opened this issue Jan 28, 2019 · 6 comments

Comments

@anp
Copy link
Member

anp commented Jan 28, 2019

From briansmith/ring#774 it's apparent that ring's author has chosen a very hardline approach to versioning their crate. It's quite possible the "correct" approach from a security perspective. Unfortunately for a project that gets less than an hour of contributor work most weeks it's not tenable to assume we'll have to keep up with an aggressive yanking policy.

Since this currently blocks anyone from contributing, I'll probably try to resolve this soon.

@dwijnand
Copy link
Member

That situation might be resolved with fixes in cargo's dependency resolution.

Though updating rfcbot's dependency versions is probably be a good thing anyway... 🙂

@anp
Copy link
Member Author

anp commented Jan 28, 2019

Yeah, I agree that updating rfcbot's dependencies is 100% the right call. I would prefer if we update them now to non-ring deps to sidestep future versioning issues at the same time.

@Centril
Copy link
Contributor

Centril commented Jan 28, 2019

We don't depend on ring directly so we'll have to wait for our dependencies to update meanwhile?

@anp
Copy link
Member Author

anp commented Jan 29, 2019

Yep. I do also think we should be evaluating ways to preclude ring from our builds in those dependency changes. I don't think the author's versioning approach is compatible with our low available bandwidth, especially considering this was discovered in the course of a new contributor sending a PR! New contributors to rfcbot are extremely rare and valuable to the Rust community and I don't want to be in a situation where newcomers might face this uphill battle in the future.

@anp
Copy link
Member Author

anp commented Jan 29, 2019

I think rwf2/cookie-rs#113 is the only potential blocker here.

@Mark-Simulacrum
Copy link
Member

No longer including ring in the dependencies, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants