Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix our config format to be more consistent #11790

Closed
Tracked by #11704
Veykril opened this issue Mar 22, 2022 · 3 comments · Fixed by #12010
Closed
Tracked by #11704

Fix our config format to be more consistent #11790

Veykril opened this issue Mar 22, 2022 · 3 comments · Fixed by #12010
Assignees
Labels
A-config configuration Broken Window Bugs / technical debt to be addressed immediately C-Architecture Big architectural things which we need to figure up-front (or suggestions for rewrites :0) )

Comments

@Veykril
Copy link
Member

Veykril commented Mar 22, 2022

As mentioned in #11789

Our configuration keys are somewhat inconsistent, we should go ahead and fixing these inconsistencies, writing down a proper structure of how configurations should look like while allowing extending them without breakage like we are slowly running into it seems.

This will requires us to do one overall change of the config format which may break user configurations but should guard us against having to do this again in the future while not restricting our options.

@Veykril Veykril added C-Architecture Big architectural things which we need to figure up-front (or suggestions for rewrites :0) ) Broken Window Bugs / technical debt to be addressed immediately A-config configuration labels Mar 22, 2022
@jonas-schievink
Copy link
Contributor

While we're at it, we should also move rust-analyzer.experimental.procAttrMacros to rust-analyzer.procMacro.enableAttrs or something, since it's really not experimental anymore.

@Veykril
Copy link
Member Author

Veykril commented Apr 14, 2022

Thinking about this, this would also allow us to reset all the aliases we have defined for now, in general cleaning up the config mess. on an additional note I wonder if we want to put a proper deprecation system in place, one that allows us to properly work with VSCode for example. The current alias system works pretty bad in it, since vscode only recognizes the one defined in the package.json, which might cause people to set the same thing multiple times through different aliases without knowing it.

@Veykril
Copy link
Member Author

Veykril commented Apr 14, 2022

Also just a headsup, but I'll fix this stuff up the coming days hopefully, but I plan on breaking things with this when we switch the extension publisher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-config configuration Broken Window Bugs / technical debt to be addressed immediately C-Architecture Big architectural things which we need to figure up-front (or suggestions for rewrites :0) )
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants