Offer "Extract variable" assist for statements

[Young-Flash]

There is a useful feature in Jetbrain IDEA, which is automatically bind a variable for an expression by a keyboard shotcut (ctrl + alt + v), showing below:

I think it would be wonderful if rust analyzer have a an feature (maybe impl via a assist💡), I'd like to make a PR if it's ok with rust analyzer team.

[lnicola]

Did you see the "Extract into variable" assist?

[Young-Flash]

seems not avaiable for the following case, am I miss something?

[lnicola]

Try selecting it, like in my screenshot.

[Young-Flash]

I got it.

It require manually select the code range, can't trigger when the cursor in the line end. May be we can refactor this?

And, can it bind with a keyboard shorcut? It's much convenient.

[lnicola]

It might be a good idea to offer it when the statement is a single function/method call (and the return type is not ()?).

I don't think you can bind a specific assist to a shortcut, but Ctrl-. will open the assists menu, and a second Ctrl-. will invoke the first one, which in this case is "extract into variable", which seems easy enough.

[Young-Flash]

It might be a good idea to offer it when the statement is a single function/method call (and the return type is not ()?).

yeah, I'd try

[rsalmei]

A curiosity @lnicola, please:
Is this "assist" popup always the "Refactor..." context menu? I did a few tests triggering them both in some places like the start and end of a line, as well as selecting it, and they seemed identical.

[lnicola]

• this assist is always "refactor" because it's marked as such
• in other cases, like let x: Vec<_> = vec![10] shows up as Rewrite in the menu
• Light bulb / Ctrl-. / right click -> Refactor are the same assists, triggered in different ways
• the latest version of VS Code will also offers assists for the current line, not just the caret position, which makes feat: make extract_variable assist in place #15809 less important