Continued flycheck issues with newest version

[mattklein123]

This is a a follow up from #18854. I don't think the underlying issue(s) are completely fixed. I just saw an example of a squiggly not going away when it should. I don't have a repro but I will report back if I find one.

[lnicola]

There's also #18864 which might help, I can trigger a pre-release build if you want to test it (or you can try one tomorrow).

[gbbosak]

I'm also seeing issues in the latest release on Fuchsia.

[gbbosak]

In my case, the diagnostics show up while Cargo is running, then disappear as soon as the invocation finishes (clearing valid errors)

[robinhundt]

I'm encountering the same issue in one codebase but not another. The only difference I can currently spot is the problematic one is a workspace, the other not.

[gbbosak]

I think the issue is that non-Cargo build systems don't have a package_id, so for those systems, trying to clear based on whether or not a package_id was received is incorrect (and it should instead be based on whether or not any diagnostics were received). I'd assume that the following would fix this (though I can't test this as we roll in prebuilt rust_analyzers and can't test specific builds in our setup).

• On a new flycheck run, clear any existing diagnostics for good measure
• Add new diagnostics

Since diagnostics from the previous run get cleared before new ones are added, I think this should solve the issue where the build system doesn't have a concept of Rust package ids.

[Veykril]

I think the issue is that non-Cargo build systems don't have a package_id, so for those systems, trying to clear based on whether or not a package_id was received is incorrect (and it should instead be based on whether or not any diagnostics were received).

That's what #18864 did

[lnicola]

Please update to v0.3.2257 and see if this still happens.

[gbbosak]

Thanks! It's fixed for us now!

[lnicola]

Optimistically closing this. Do say if you run into it again.

[mattklein123]

@lnicola I can open a new issue but one behavior change I have noticed is the following: in a project with multiple crates, a compilation error in a dependent crate no longer clears flycheck errors/squiggles in dependee crates. Personally I find this confusing and prefer the old behavior. If this is a bug I can open a new issue on that.

[Veykril]

Basically you have crate A depend on B, A has errors, now you change things such that B has errors. B gets updated to show the errors but A is not being cleared? Indeed I think that should be improved (we should clear everything untouched at the end)