Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ra_prof: use tracing? #3794

Closed
kjeremy opened this issue Mar 31, 2020 · 5 comments
Closed

ra_prof: use tracing? #3794

kjeremy opened this issue Mar 31, 2020 · 5 comments
Labels
S-actionable Someone could pick this issue up and work on it right now

Comments

@kjeremy
Copy link
Contributor

kjeremy commented Mar 31, 2020

As seen on zulip: https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/tracing.20in.20chalk/near/192417961

https://github.com/davidbarsky/tracing-tree/

@bjorn3
Copy link
Member

bjorn3 commented Mar 31, 2020

Another option would be measureme which is used by rustc.

@Veetaha
Copy link
Contributor

Veetaha commented Mar 31, 2020

Not sure if we can use it in Rust, but the flamegraph impl is here: https://github.com/jonhoo/inferno

@davidbarsky
Copy link
Contributor

(Hi, I'm David!)

I think I speak for Eliza when I say we'd be super happy if you did end up using tracing! Beyond the tracing-tree library I wrote, @yaahc has been working on flamegraph/inferno integration with tracing here: tokio-rs/tracing#631. I'll see what the status of that PR is and if it can be merged soon.

@yaahc
Copy link
Member

yaahc commented Apr 2, 2020

just finished the fix with the thread_local so now it should give accurate samples for multiple threads, I'll see if we can't get it merged today.

@lnicola lnicola added the S-actionable Someone could pick this issue up and work on it right now label Jan 26, 2021
@Veykril Veykril self-assigned this Jan 3, 2022
@Veykril Veykril removed their assignment Jan 17, 2022
@lnicola
Copy link
Member

lnicola commented Feb 5, 2024

@davidbarsky I think we can close this, right?

@lnicola lnicola closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Development

No branches or pull requests

7 participants