-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The book doesn't really work locally #1106
Comments
I think this should be on mdbook, but I'd have to double check. We want everything to work offline, but maybe something regressed... |
Hardcoded rust-by-example/theme/index.hbs Line 12 in bc342a4
Hardcoded rust-by-example/theme/index.hbs Line 52 in bc342a4
Hardcoded cdn urls: rust-by-example/theme/index.hbs Lines 13 to 14 in bc342a4
rust-by-example/theme/index.hbs Line 19 in bc342a4
rust-by-example/theme/index.hbs Line 32 in bc342a4
rust-by-example/theme/index.hbs Line 36 in bc342a4
rust-by-example/theme/index.hbs Line 44 in bc342a4
Thus fails to render locally even when allowed CDNs (possibly due to EDIT: Note to self: it works but must build using mdBook 0.1.7 Thanks steveklabnik |
I tried it using the latest mdbook (2.2) and it doesn't work. It tries and fails to connect to a whole bunch of sites. Also, once I do connect to the internet, it still doesn't display correctly, and half of the chapter links don't work. This is how it renders on every page (that works). The complete TOC listed in full on every page is how it actually renders (in FF).
Edit Rust provides access to a wide variety of
Despite the value of a unit type being a tuple, it is not considered a compound type because it does not contain multiple values.
Variables can always be type annotated. Numbers may additionally be annotated via a suffix or by default. Integers default to fn main() {
} See also: the |
You might have to use (like I did) mdBook version |
works for me today even though I've The only thing is trying to get from the internet is two fonts.googleapis.com fonts. |
Hello,
While trying to solve another problem (#1105), I noticed that it doesn't really work locally. I was trying with mdbook 0.1.8 in the train while commuting this morning, and page rendering was blocked by the several calls to CDNs for various js libs. Since I was connected but had poor connectivity, the downloads of the js libs never really happened but the browser kept trying in vain. I expected the book to work fully locally since the README says
If you'd like to read it locally
-- apart from running the code, but at least this part is explicit in the README.I think of several things that could solve the problem:
async
to thescript
tags so they don't block the rendering of the HTML,script
tags to the end,I know nothing about
mdbook
, maybe it should be done there? Maybe it's specific torust-by-example
? Maybe these things have already been discussed and the current situation is what you want?The text was updated successfully, but these errors were encountered: