Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo (FromIter instead of FromIterator) #1613

Closed
DenisNavarro opened this issue Sep 25, 2022 · 2 comments
Closed

Typo (FromIter instead of FromIterator) #1613

DenisNavarro opened this issue Sep 25, 2022 · 2 comments

Comments

@DenisNavarro
Copy link
Contributor

Hello.

In "18.6. Iterating over Results", it is written:

Result implements FromIter

instead of:

Result implements FromIterator

Source: https://github.com/rust-lang/rust-by-example/blob/767a6bd9727a596d7cfdbaeee475e65b2670ea3a/src/error/iter_result.md#fail-the-entire-operation-with-collect

I tried to push a new branch fix_typo_in_trait_name with the typo fix, but I got an error ERROR: Permission to rust-lang/rust-by-example.git denied to DenisNavarro.
@DenisNavarro
Copy link
Contributor Author

I just learned that the permission denied was normal. I was used to follow a workflow in companies in which the pull requests were not from a fork.

This time, I did a pull request with the correct process: #1614

@DenisNavarro DenisNavarro changed the title Typo (FromIter instead of FromIterator) and permission denied when trying to push a new branch Typo (FromIter instead of FromIterator) Sep 26, 2022
@DenisNavarro
Copy link
Contributor Author

Pull request successfully merged and closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DenisNavarro