Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing_inline_in_public_items probably doesn't make sense in crates intended for procedural macros #6486

Closed
c410-f3r opened this issue Dec 21, 2020 · 1 comment · Fixed by #6814
Closed

missing_inline_in_public_items probably doesn't make sense in crates intended for procedural macros #6486

c410-f3r opened this issue Dec 21, 2020 · 1 comment · Fixed by #6814
Labels
C-bug Category: Clippy is not doing the correct thing good-first-issue These issues are a good way to get started with Clippy I-false-positive Issue: The lint was triggered on code it shouldn't have

Comments

@c410-f3r
Copy link
Contributor

c410-f3r commented Dec 21, 2020 •
edited by rustbot
Loading 

#![forbid(clippy::missing_inline_in_public_items)]

#[proc_macro]
pub fn foo(stuff: proc_macro::TokenStream) -> proc_macro::TokenStream { // ERROR !
  stuff
}
@camsteffen camsteffen added good-first-issue These issues are a good way to get started with Clippy C-bug Category: Clippy is not doing the correct thing I-false-positive Issue: The lint was triggered on code it shouldn't have labels Jan 26, 2021
@ghost
Copy link

ghost commented Feb 28, 2021

@rustbot claim
(I'm going to change is_executable to is_executable_or_proc_macro and add a test.)

@rustbot rustbot assigned ghost Feb 28, 2021
@ghost ghost mentioned this issue Feb 28, 2021
Merged
@bors bors closed this as completed in 8222d48 Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: Clippy is not doing the correct thing good-first-issue These issues are a good way to get started with Clippy I-false-positive Issue: The lint was triggered on code it shouldn't have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix false positives on procedural macros of missing_inline_in_public_items lint
2 participants
@camsteffen @c410-f3r