From 7c563175c7b2e7eeb2a917707c09236b77321946 Mon Sep 17 00:00:00 2001 From: Alex Macleod Date: Fri, 21 Jan 2022 12:40:33 +0000 Subject: [PATCH] Don't suggest an empty variant name in `enum_variant_names` --- clippy_lints/src/enum_variants.rs | 3 +++ tests/ui/enum_variants.rs | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/clippy_lints/src/enum_variants.rs b/clippy_lints/src/enum_variants.rs index 4f89e5674306..1f4353fa4f72 100644 --- a/clippy_lints/src/enum_variants.rs +++ b/clippy_lints/src/enum_variants.rs @@ -172,6 +172,9 @@ fn check_variant(cx: &LateContext<'_>, threshold: u64, def: &EnumDef<'_>, item_n let name = var.ident.name.as_str(); let variant_split = camel_case_split(name); + if variant_split.len() == 1 { + return; + } pre = pre .iter() diff --git a/tests/ui/enum_variants.rs b/tests/ui/enum_variants.rs index d3662a0a213d..b2bf7c4e360a 100644 --- a/tests/ui/enum_variants.rs +++ b/tests/ui/enum_variants.rs @@ -151,4 +151,11 @@ enum North { NoRight, } +// #8324 +enum Phase { + PreLookup, + Lookup, + PostLookup, +} + fn main() {}