diff --git a/src/librustc_metadata/creader.rs b/src/librustc_metadata/creader.rs index d0237071a6058..16fbd2c5b56a5 100644 --- a/src/librustc_metadata/creader.rs +++ b/src/librustc_metadata/creader.rs @@ -242,7 +242,6 @@ impl<'a> CrateLoader<'a> { cnum_map: Lock::new(cnum_map), cnum, codemap_import_info: RwLock::new(vec![]), - attribute_cache: Lock::new([Vec::new(), Vec::new()]), dep_kind: Lock::new(dep_kind), source: cstore::CrateSource { dylib, diff --git a/src/librustc_metadata/cstore.rs b/src/librustc_metadata/cstore.rs index 64bbcf436cb9e..6fa19323ff06c 100644 --- a/src/librustc_metadata/cstore.rs +++ b/src/librustc_metadata/cstore.rs @@ -67,7 +67,6 @@ pub struct CrateMetadata { pub cnum_map: Lock, pub cnum: CrateNum, pub codemap_import_info: RwLock>, - pub attribute_cache: Lock<[Vec>>; 2]>, pub root: schema::CrateRoot, diff --git a/src/librustc_metadata/decoder.rs b/src/librustc_metadata/decoder.rs index 57f92707ccfe3..38eb0109f2ab2 100644 --- a/src/librustc_metadata/decoder.rs +++ b/src/librustc_metadata/decoder.rs @@ -880,34 +880,22 @@ impl<'a, 'tcx> CrateMetadata { } pub fn get_item_attrs(&self, node_id: DefIndex, sess: &Session) -> Lrc<[ast::Attribute]> { - let (node_as, node_index) = - (node_id.address_space().index(), node_id.as_array_index()); if self.is_proc_macro(node_id) { return Lrc::new([]); } - if let Some(&Some(ref val)) = - self.attribute_cache.borrow()[node_as].get(node_index) { - return val.clone(); - } - // The attributes for a tuple struct are attached to the definition, not the ctor; // we assume that someone passing in a tuple struct ctor is actually wanting to // look at the definition - let mut item = self.entry(node_id); let def_key = self.def_key(node_id); - if def_key.disambiguated_data.data == DefPathData::StructCtor { - item = self.entry(def_key.parent.unwrap()); - } - let result: Lrc<[ast::Attribute]> = Lrc::from(self.get_attributes(&item, sess)); - let vec_ = &mut self.attribute_cache.borrow_mut()[node_as]; - if vec_.len() < node_index + 1 { - vec_.resize(node_index + 1, None); - } - // This can overwrite the result produced by another thread, but the value - // written should be the same - vec_[node_index] = Some(result.clone()); - result + let item_id = if def_key.disambiguated_data.data == DefPathData::StructCtor { + def_key.parent.unwrap() + } else { + node_id + }; + + let item = self.entry(item_id); + Lrc::from(self.get_attributes(&item, sess)) } pub fn get_struct_field_names(&self, id: DefIndex) -> Vec {